[SPARK-37029][Shuffle] Modify the assignment logic of dirFetchRequests variables #34304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinhai-cloud
changed the title
|
Can one of the admins verify this patch? |
HyukjinKwon
changed the title
Ngone51
reviewed
Oct 18, 2021
| hostLocalBlocksWithMissingDirs.keys.map(bmId => (bmId.host, bmId.port, Array(bmId))).toSeq | ||
| } | ||
| val dirFetchRequests = hostLocalBlocksWithMissingDirs.keys.map(bmId => | ||
| (bmId.host, bmId.port, Array(bmId))).toSeq |
There was a problem hiding this comment.
I think there's a behavior difference after the change - previously, there would be only one call on getHostLocalDirs below. After this change, it becomes the number of hostLocalBlocksWithMissingDirs, which could introduce more RPC calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the ShuffleBlockFetcherIterator.fetchHostLocalBlocks method, we generate dirFetchRequests based on externalShuffleServiceEnabled. But in fact, the MapStatus object generated in the shuffle write phase had already generated the BlockManagerId object according to externalShuffleServiceEnabled in the BlockManager.initialize method.
So we don't need to judge it again.
Why are the changes needed?
Does this PR introduce any user-facing change?
No
How was this patch tested?