New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-37086][R][ML][TESTS] Fix the R test of FPGrowthModel for Scala 2.13 #34357
Conversation
Test build #144509 has finished for PR 34357 at commit
|
Kubernetes integration test starting |
Kubernetes integration test status failure |
Could you check |
Hmm, recently, AppVeyor seems to fail almost every time. But I'll re-trigger it. |
Test build #144512 has finished for PR 34357 at commit
|
Kubernetes integration test starting |
Test build #144513 has finished for PR 34357 at commit
|
Kubernetes integration test status failure |
Test build #144514 has finished for PR 34357 at commit
|
Kubernetes integration test starting |
Kubernetes integration test status failure |
AppVeyor is very flaky .. I tried so hard to fix but no luck 😢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merged to master. |
What changes were proposed in this pull request?
This PR fixes an issue that the R test of FPGrowthModel fails with Scala 2.13.
Similar to the issue filed in SPARK-37059 (#34330), the R test of FPGrowthModel assumes that the result records returned by
FPGrowthModel.freqItemsets
are sorted by a certain kind of order but it's wrong.As a result, the test fails with Scala 2.13.
Why are the changes needed?
For test stability.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
All the R tests passed on GA with a modified GA config to run with Scala 2.13 (set
scala2.13
to theSPARK_PROFILE
environment variable).https://github.com/sarutak/spark/runs/3964081433?check_suite_focus=true#step:7:380
Test for Scala 2.12 should be done on the regular GA.