Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-37171][SQL]Add forany and forall to Datasets/Dataframes #34450

Closed
wants to merge 1 commit into from
Closed

[SPARK-37171][SQL]Add forany and forall to Datasets/Dataframes #34450

wants to merge 1 commit into from

Conversation

dhirennavani
Copy link
Contributor

@dhirennavani dhirennavani commented Oct 31, 2021

What changes were proposed in this pull request?

Add forany and forall api for Dataframe/Datasets API

Why are the changes needed?

To provide a higher level of abstraction for Spark customers

Does this PR introduce any user-facing change?

Yes, forany and forall methods are added to the Dataframe/Dataset API

How was this patch tested?

Added new unit tests

Add forany and forall api for Dataframe/Datasets API

To provide a higher level of abstraction for Spark customers

Yes, forany and forall methods are added to the Dataframe/Dataset API

Added new unit tests
@github-actions github-actions bot added the SQL label Oct 31, 2021
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@srowen
Copy link
Member

srowen commented Oct 31, 2021

Why add these?

@dhirennavani
Copy link
Contributor Author

I have mentioned in the ticket the potential for implementing the unoptimized version and provide a little higher abstraction.

* }}}
*
* @group typedrel
* @since 3.2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can't be since 3.2.0
This would have to be in R, Scala APIs too
But this doesn't seem worth it - it isn't faster to execute

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That’s true. So do you recommend we drop this as it would be too much to implement in R and Python?

I believe the code is for Scala API.
Just FYI, isEmpty method is absent in Python API although present in Scala API.

Let me know if we still wanna go forward, I can change the version then. If you let me know the right version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry yes I meant Python/R. I don't think this is worthwhile if it isn't optimizing or saving the caller much code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problems :)

i will close the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants