Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-36895][SQL][FOLLOWUP] CREATE INDEX command should rely on the analyzer framework to resolve columns #34467

Closed
wants to merge 2 commits into from
Closed

[SPARK-36895][SQL][FOLLOWUP] CREATE INDEX command should rely on the analyzer framework to resolve columns #34467

wants to merge 2 commits into from

Conversation

cloud-fan
Copy link
Contributor

What changes were proposed in this pull request?

This PR leverages the existing framework to resolve columns in the CREATE INDEX command.

Why are the changes needed?

To fail earlier instead of passing invalid column names to v2 sources.

Does this PR introduce any user-facing change?

no

How was this patch tested?

new test

@cloud-fan
Copy link
Contributor Author

@huaxingao

@github-actions github-actions bot added the SQL label Nov 2, 2021
@SparkQA
Copy link

SparkQA commented Nov 2, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49316/

@SparkQA
Copy link

SparkQA commented Nov 2, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49316/

@SparkQA
Copy link

SparkQA commented Nov 2, 2021

Test build #144845 has finished for PR 34467 at commit fe2115e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

huaxingao
huaxingao reviewed Nov 2, 2021
View reviewed changes
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
@@ -4439,7 +4439,7 @@ class AstBuilder extends SqlBaseBaseVisitor[AnyRef] with SQLConfHelper with Logg
indexName,
indexType,
ctx.EXISTS != null,
columns.map(FieldReference(_).asInstanceOf[FieldReference]).zip(columnsProperties),
columns.map(UnresolvedFieldName(_)).zip(columnsProperties),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed this failed with scala 2.13. Add .toSeq?

@SparkQA
Copy link

SparkQA commented Nov 2, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49321/

@SparkQA
Copy link

SparkQA commented Nov 2, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49321/

@SparkQA
Copy link

SparkQA commented Nov 2, 2021

Test build #144851 has finished for PR 34467 at commit 67040eb.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@huaxingao
Copy link
Contributor

The GA failure doesn't seem to be relevant to this PR. I will merge.

@huaxingao huaxingao closed this in 293c085 Nov 2, 2021
@huaxingao
Copy link
Contributor

Merged to master. Thank you very much! @cloud-fan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huaxingao huaxingao huaxingao approved these changes

Assignees
No one assigned
Labels
SQL
Projects
None yet
Milestone
No milestone
3 participants
@cloud-fan @SparkQA @huaxingao