Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-37221][SQL][FOLLOWUP] Add toRowBased to SparkPlan #34538

Closed
wants to merge 1 commit into from

Conversation

viirya
Copy link
Member

@viirya viirya commented Nov 9, 2021

What changes were proposed in this pull request?

This is a follow up of #34499. Instead of adding ColumnarToRowExec in getByteArrayRdd, this patch adds toRowBased API to explicitly ask for columnar-to-row-based conversion.

Why are the changes needed?

To make the conversion selectable.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Existing tests.

@viirya
Copy link
Member Author

viirya commented Nov 9, 2021

cc @cloud-fan

@github-actions github-actions bot added the SQL label Nov 9, 2021
@SparkQA
Copy link

SparkQA commented Nov 9, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49509/

@SparkQA
Copy link

SparkQA commented Nov 9, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49509/

@SparkQA
Copy link

SparkQA commented Nov 10, 2021

Test build #145038 has finished for PR 34538 at commit 0d36732.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya
Copy link
Member Author

viirya commented Nov 10, 2021

Thanks @dongjoon-hyun ! Merging to master.

@viirya viirya closed this in e1f3f22 Nov 10, 2021
@viirya viirya deleted the columnar-followup branch November 10, 2021 03:11
@cloud-fan
Copy link
Contributor

late LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants