New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-37293][TESTS] Remove explicit GC options from Scala tests #34560
Conversation
Hi, @HyukjinKwon and @LuciferYang .
|
Kubernetes integration test starting |
Kubernetes integration test status failure |
Test build #145117 has finished for PR 34560 at commit
|
Could you review this, @mridulm ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only concern is the tests being flaky - the current GA builds are flaky because of hitting memory issues. I vaguely remember that using UseParallelGC
arguably less reaches the memory limit (I did take a quick look before).
I am going to approve this but we might have to monitor the tests for the time being..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1
Thanks. Yes, GA jobs are flaky due to the memory limits and I'll monitor this carefully. Note that this will affect only Java 11/Java 17 which means
The other jobs are running Java 8 whose default GC is Especially, this PR aims to stablize the daily Java11 and Java17 jobs. I'll keep improving those test coverage for Spark 3.3.. |
Thank you, @LuciferYang , too. Merged to master. |
This PR aims to remove the explicit GC options in Scala tests. At Apache Spark 3.0, SPARK-29282 introduced the explicit GC options in Scala tests to see the consistent result between Java8/Java11. Now, we have Java 17 additionally and SPARK-37120 added Java 11/17 GitHub Action jobs. This PR aims to use the default GC options for each JVM. This is a partial revert of SPARK-29282. No. Pass the GitHub Action CIs without memory issues. Closes apache#34560 from dongjoon-hyun/SPARK-37293. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 5b002c8) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
What changes were proposed in this pull request?
This PR aims to remove the explicit GC options in Scala tests.
Why are the changes needed?
At Apache Spark 3.0, SPARK-29282 introduced the explicit GC options in Scala tests to see the consistent result between Java8/Java11. Now, we have Java 17 additionally and SPARK-37120 added Java 11/17 GitHub Action jobs.
This PR aims to use the default GC options for each JVM. This is a partial revert of SPARK-29282.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the GitHub Action CIs without memory issues.