[SPARK-37453][INFRA][SQL][TESTS] Split TPC-DS build in GitHub Actions #34698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
changed the title
This comment has been minimized.
This comment has been minimized.
HyukjinKwon
force-pushed
the
split-tpcds
branch
from
c37e174
to
4fd65df
Compare
HyukjinKwon
changed the title
This comment has been minimized.
This comment has been minimized.
HyukjinKwon
force-pushed
the
split-tpcds
branch
3 times, most recently
from
2ffa2da
to
36b3473
Compare
HyukjinKwon
commented
Nov 24, 2021
| joinConfSet.tail.foreach { conf => | ||
| System.gc() // SPARK-37368 | ||
| runQuery(queryString, goldenFile, conf.toSeq, true) | ||
| } |
There was a problem hiding this comment.
While I am here, I ended up with refactoring this code part here. No behavior change. Everything is as was.
This comment has been minimized.
This comment has been minimized.
|
cc @cloud-fan, @linhongliu-db and @jerqi |
HyukjinKwon
force-pushed
the
split-tpcds
branch
from
36b3473
to
89b98d4
Compare
This comment has been minimized.
This comment has been minimized.
cloud-fan
approved these changes
Nov 24, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jerqi
reviewed
Nov 24, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Tests passed. Merged to master. |
|
Kubernetes integration test status failure |
|
Test build #145596 has finished for PR 34698 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is kind of a followup for #33510 and #34641. This PR proposes to split TPC-DS build in GitHub Actions.
Why are the changes needed?
Running these queries easily causes out-of-memory in GitHub Actions machines, and make the build flaky. We should deflake it.
Does this PR introduce any user-facing change?
No, dev-only.
How was this patch tested?
GitHub Actions in this PR should test it out.