Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-37460][DOCS] Add the description of ALTER DATABASE SET LOCATION #34718

Closed
wants to merge 3 commits into from
Closed

[SPARK-37460][DOCS] Add the description of ALTER DATABASE SET LOCATION #34718

wants to merge 3 commits into from

Conversation

yutoacts
Copy link
Contributor

What changes were proposed in this pull request?

Added the description of ALTER DATABASE SET LOCATION command in sql-ref-syntax-ddl-alter-database.md

Why are the changes needed?

This command can be used but not documented anywhere.

Does this PR introduce any user-facing change?

Yes, docs changes.

How was this patch tested?

SKIP_API=1 bundle exec jekyll build
alterdb1
alterdb2

@github-actions github-actions bot added the DOCS label Nov 26, 2021
@SparkQA
Copy link

SparkQA commented Nov 26, 2021

Test build #145647 has finished for PR 34718 at commit a5a23a1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@sarutak
Copy link
Member

sarutak commented Nov 26, 2021

cc: @imback82

@SparkQA
Copy link

SparkQA commented Nov 26, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50118/

@SparkQA
Copy link

SparkQA commented Nov 26, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50118/

@yutoacts
Copy link
Contributor Author

cc @cloud-fan

imback82
imback82 reviewed Nov 30, 2021
View reviewed changes
Copy link
Contributor

@imback82 imback82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

docs/sql-ref-syntax-ddl-alter-database.md Outdated Show resolved Hide resolved
@SparkQA
Copy link

SparkQA commented Dec 1, 2021

Test build #145786 has finished for PR 34718 at commit 6bf5660.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 1, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50259/

@SparkQA
Copy link

SparkQA commented Dec 1, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50259/

cloud-fan
cloud-fan reviewed Dec 1, 2021
View reviewed changes
docs/sql-ref-syntax-ddl-alter-database.md Outdated
`ALTER DATABASE SET LOCATION` statement changes the default parent-directory where new tables will be added
for a database. Please note that it does not move the contents of the database's current directory to the newly
specified location or change the locations associated with any tables/partitions under the specified database
(available in Hive 3.0.0 and later).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we find out the Spark version instead?

Copy link
Contributor Author

@yutoacts yutoacts Dec 1, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review. I mentioned the Hive version here because the usability of the ALTER DATABASE SET LOCATION command depends on the version of the Hive metastore and it is not available on 2.3.9.
I will add the Spark version here (Spark 3.0.0 and later) but I think it's still good for users to write about Hive.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

@SparkQA
Copy link

SparkQA commented Dec 1, 2021

Test build #145811 has finished for PR 34718 at commit 7cd9956.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 1, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50285/

@SparkQA
Copy link

SparkQA commented Dec 1, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50285/

@cloud-fan
Copy link
Contributor

cloud-fan commented Dec 1, 2021 •
edited

thanks, merging to master/3.2!

@cloud-fan cloud-fan closed this in 5924961 Dec 1, 2021
cloud-fan pushed a commit that referenced this pull request Dec 1, 2021
@cloud-fan
[SPARK-37460][DOCS] Add the description of ALTER DATABASE SET LOCATION
46fc98c 
### What changes were proposed in this pull request?

Added the description of `ALTER DATABASE SET LOCATION` command in `sql-ref-syntax-ddl-alter-database.md`

### Why are the changes needed?

This command can be used but not documented anywhere.

### Does this PR introduce _any_ user-facing change?

Yes, docs changes.

### How was this patch tested?

`SKIP_API=1 bundle exec jekyll build`
<img width="395" alt="alterdb1" src="https://user-images.githubusercontent.com/87687356/143523751-4cc32ad1-390c-491b-a6ea-bf1664535c28.png">
<img width="396" alt="alterdb2" src="https://user-images.githubusercontent.com/87687356/143523757-aa741d74-0e51-4e17-8768-9da7eb86a7d8.png">

Closes #34718 from yutoacts/SPARK-37460.

Authored-by: Yuto Akutsu <yuto.akutsu@oss.nttdata.com>
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
(cherry picked from commit 5924961)
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
catalinii pushed a commit to lyft/spark that referenced this pull request Feb 22, 2022
[SPARK-37460][DOCS] Add the description of ALTER DATABASE SET LOCATION
e039c54 
### What changes were proposed in this pull request?

Added the description of `ALTER DATABASE SET LOCATION` command in `sql-ref-syntax-ddl-alter-database.md`

### Why are the changes needed?

This command can be used but not documented anywhere.

### Does this PR introduce _any_ user-facing change?

Yes, docs changes.

### How was this patch tested?

`SKIP_API=1 bundle exec jekyll build`
<img width="395" alt="alterdb1" src="https://user-images.githubusercontent.com/87687356/143523751-4cc32ad1-390c-491b-a6ea-bf1664535c28.png">
<img width="396" alt="alterdb2" src="https://user-images.githubusercontent.com/87687356/143523757-aa741d74-0e51-4e17-8768-9da7eb86a7d8.png">

Closes apache#34718 from yutoacts/SPARK-37460.

Authored-by: Yuto Akutsu <yuto.akutsu@oss.nttdata.com>
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
(cherry picked from commit 5924961)
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
catalinii pushed a commit to lyft/spark that referenced this pull request Mar 4, 2022
@catalinii
[SPARK-37460][DOCS] Add the description of ALTER DATABASE SET LOCATION
bb18af0 
### What changes were proposed in this pull request?

Added the description of `ALTER DATABASE SET LOCATION` command in `sql-ref-syntax-ddl-alter-database.md`

### Why are the changes needed?

This command can be used but not documented anywhere.

### Does this PR introduce _any_ user-facing change?

Yes, docs changes.

### How was this patch tested?

`SKIP_API=1 bundle exec jekyll build`
<img width="395" alt="alterdb1" src="https://user-images.githubusercontent.com/87687356/143523751-4cc32ad1-390c-491b-a6ea-bf1664535c28.png">
<img width="396" alt="alterdb2" src="https://user-images.githubusercontent.com/87687356/143523757-aa741d74-0e51-4e17-8768-9da7eb86a7d8.png">

Closes apache#34718 from yutoacts/SPARK-37460.

Authored-by: Yuto Akutsu <yuto.akutsu@oss.nttdata.com>
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
(cherry picked from commit 5924961)
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
@yutoacts yutoacts deleted the SPARK-37460 branch March 6, 2022 05:14
kazuyukitanimura pushed a commit to kazuyukitanimura/spark that referenced this pull request Aug 10, 2022
@viirya
[SPARK-37460][DOCS] Add the description of ALTER DATABASE SET LOCATION
0893f81 
### What changes were proposed in this pull request?

Added the description of `ALTER DATABASE SET LOCATION` command in `sql-ref-syntax-ddl-alter-database.md`

### Why are the changes needed?

This command can be used but not documented anywhere.

### Does this PR introduce _any_ user-facing change?

Yes, docs changes.

### How was this patch tested?

`SKIP_API=1 bundle exec jekyll build`
<img width="395" alt="alterdb1" src="https://user-images.githubusercontent.com/87687356/143523751-4cc32ad1-390c-491b-a6ea-bf1664535c28.png">
<img width="396" alt="alterdb2" src="https://user-images.githubusercontent.com/87687356/143523757-aa741d74-0e51-4e17-8768-9da7eb86a7d8.png">

Closes apache#34718 from yutoacts/SPARK-37460.

Authored-by: Yuto Akutsu <yuto.akutsu@oss.nttdata.com>
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
(cherry picked from commit 5924961)
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imback82 imback82 imback82 left review comments

@cloud-fan cloud-fan cloud-fan approved these changes

@dongjoon-hyun dongjoon-hyun dongjoon-hyun approved these changes

Assignees
No one assigned
Labels
DOCS
Projects
None yet
Milestone
No milestone
6 participants
@yutoacts @SparkQA @sarutak @cloud-fan @dongjoon-hyun @imback82