[SPARK-37467][SQL] Consolidate whole stage and non whole stage subexpression elimination #34727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@viirya. I've been playing around with this and I haven't thought of any breaking cases, but curious if there's anything you can think of or problems with this approach. Mostly trying to consolidate things before playing around with subexpression elimination inside of lambda functions. |
|
Can one of the admins verify this patch? |
Kimahriman
force-pushed
the
consolidate-subexpr-elimination
branch
3 times, most recently
from
233de65
to
8fe5f0b
Compare
Kimahriman
force-pushed
the
consolidate-subexpr-elimination
branch
from
8fe5f0b
to
c245738
Compare
Kimahriman
force-pushed
the
consolidate-subexpr-elimination
branch
from
c245738
to
7d754a0
Compare
Kimahriman
force-pushed
the
consolidate-subexpr-elimination
branch
from
7d754a0
to
51d8657
Compare
Kimahriman
force-pushed
the
consolidate-subexpr-elimination
branch
from
51d8657
to
eec318f
Compare
Kimahriman
force-pushed
the
consolidate-subexpr-elimination
branch
from
eec318f
to
a9e5151
Compare
Kimahriman
force-pushed
the
consolidate-subexpr-elimination
branch
from
a9e5151
to
adaa8d1
Compare
Kimahriman
force-pushed
the
consolidate-subexpr-elimination
branch
from
adaa8d1
to
70b8441
Compare
Kimahriman
force-pushed
the
consolidate-subexpr-elimination
branch
from
70b8441
to
e35f5bc
Compare
Kimahriman
force-pushed
the
consolidate-subexpr-elimination
branch
from
e35f5bc
to
16d897d
Compare
Kimahriman
force-pushed
the
consolidate-subexpr-elimination
branch
from
16d897d
to
7560c20
Compare
Kimahriman
force-pushed
the
consolidate-subexpr-elimination
branch
from
7560c20
to
0c803ed
Compare
Kimahriman
force-pushed
the
consolidate-subexpr-elimination
branch
from
0c803ed
to
e6a113a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR consolidates the code paths for subexpression elimination in whole stage and non-whole stage codegen. Whole stage codegen seemed to be mostly a superset of the non-whole stage subexpression elimination, just with whole stage not using the codegen context to track subexpressions. Since subexpression values are replaced with empty blocks when evaluated, the context should be able to track the subexpressions across multiple operators. Not sure if there's corner cases I'm missing though.
It shouldn't result in any functionality changes, but there are slight differences in the generated code as a result of this:
Why are the changes needed?
Currently, there are different code paths to handle subexpression elimination in whole stage and non-whole stage codegen. This makes it harder to add new capabilities to subexpression elimination having to deal with independent code paths.
Does this PR introduce any user-facing change?
No, just slight changes in generated code.
How was this patch tested?
Existing unit tests.