[SPARK-37534][BUILD][3.2] Bump dev.ludovic.netlib to 2.2.1 #34797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok to test |
HyukjinKwon
changed the title
|
@luhenry mind filling other sections in the PR description? |
2.2.1 fixes a bug in sgemm
|
@HyukjinKwon I updated it. Is it enough details, or should I add some more? |
|
👍 |
luhenry
force-pushed
the
branch-3.2-bump-netlib
branch
from
d723b83
to
eb6f8cc
Compare
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #145899 has finished for PR 34797 at commit
|
HyukjinKwon
approved these changes
Dec 3, 2021
|
Can one of the admins verify this patch? |
dongjoon-hyun
approved these changes
Dec 3, 2021
There was a problem hiding this comment.
+1, LGTM. Thank you, @luhenry and @HyukjinKwon .
Merged to branch-3.2 for Apache Spark 3.2.1.
dongjoon-hyun
pushed a commit
that referenced
this pull request
Dec 3, 2021
### What changes were proposed in this pull request? Bump the version of dev.ludovic.netlib from 2.2.0 to 2.2.1. ### Why are the changes needed? This fixes a computation bug in sgemm. See [the issue](luhenry/netlib#7) and [the diff](luhenry/netlib@v2.2.0...v2.2.1). ### Does this PR introduce _any_ user-facing change? No. It fixes the underlying computation of a single floating point matrix-matrix multiplication. ### How was this patch tested? Additional tests were added to the dev.ludovic.netlib project, and a CI run has validated the change. Closes #34797 from luhenry/branch-3.2-bump-netlib. Authored-by: Ludovic Henry <git@ludovic.dev> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
catalinii
pushed a commit
to lyft/spark
that referenced
this pull request
Feb 22, 2022
### What changes were proposed in this pull request? Bump the version of dev.ludovic.netlib from 2.2.0 to 2.2.1. ### Why are the changes needed? This fixes a computation bug in sgemm. See [the issue](luhenry/netlib#7) and [the diff](luhenry/netlib@v2.2.0...v2.2.1). ### Does this PR introduce _any_ user-facing change? No. It fixes the underlying computation of a single floating point matrix-matrix multiplication. ### How was this patch tested? Additional tests were added to the dev.ludovic.netlib project, and a CI run has validated the change. Closes apache#34797 from luhenry/branch-3.2-bump-netlib. Authored-by: Ludovic Henry <git@ludovic.dev> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
catalinii
pushed a commit
to lyft/spark
that referenced
this pull request
Mar 4, 2022
### What changes were proposed in this pull request? Bump the version of dev.ludovic.netlib from 2.2.0 to 2.2.1. ### Why are the changes needed? This fixes a computation bug in sgemm. See [the issue](luhenry/netlib#7) and [the diff](luhenry/netlib@v2.2.0...v2.2.1). ### Does this PR introduce _any_ user-facing change? No. It fixes the underlying computation of a single floating point matrix-matrix multiplication. ### How was this patch tested? Additional tests were added to the dev.ludovic.netlib project, and a CI run has validated the change. Closes apache#34797 from luhenry/branch-3.2-bump-netlib. Authored-by: Ludovic Henry <git@ludovic.dev> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
kazuyukitanimura
pushed a commit
to kazuyukitanimura/spark
that referenced
this pull request
Aug 10, 2022
### What changes were proposed in this pull request? Bump the version of dev.ludovic.netlib from 2.2.0 to 2.2.1. ### Why are the changes needed? This fixes a computation bug in sgemm. See [the issue](luhenry/netlib#7) and [the diff](luhenry/netlib@v2.2.0...v2.2.1). ### Does this PR introduce _any_ user-facing change? No. It fixes the underlying computation of a single floating point matrix-matrix multiplication. ### How was this patch tested? Additional tests were added to the dev.ludovic.netlib project, and a CI run has validated the change. Closes apache#34797 from luhenry/branch-3.2-bump-netlib. Authored-by: Ludovic Henry <git@ludovic.dev> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Bump the version of dev.ludovic.netlib from 2.2.0 to 2.2.1.
Why are the changes needed?
This fixes a computation bug in sgemm. See the issue and the diff.
Does this PR introduce any user-facing change?
No. It fixes the underlying computation of a single floating point matrix-matrix multiplication.
How was this patch tested?
Additional tests were added to the dev.ludovic.netlib project, and a CI run has validated the change.