[SPARK-35437][SQL][FOLLOWUP] Relax cast if does not need timezone with PrunePartitionsFastFallback #34981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kubernetes integration test starting |
|
Test build #146470 has finished for PR 34981 at commit
|
|
Kubernetes integration test status failure |
cloud-fan
approved these changes
Dec 22, 2021
|
Can you link to the original PR in your PR description? |
updated |
|
thanks, merging to master! |
|
thank you @cloud-fan |
domybest11
pushed a commit
to domybest11/spark
that referenced
this pull request
Jun 15, 2022
…h PrunePartitionsFastFallback Allow `Cast` during `prunePartitionsFastFallback` if it actually does not require the timezone. The original PR apache#34431 Make `prunePartitionsFastFallback` work with more cases. For example, one partition column data type is `StringType` but the query with the partition predicate using `IntegerType` ```sql CREATE TABLE t(c int) PARTITIONED BY(p string); SELECT * FROM t WHERE p = 20210101; ``` no, not released and this pr itself just affects the perf. Add some test for `Cast` who need or does not need time zone. Closes apache#34981 from ulysses-you/SPARK-35437-FOLLOWUP. Authored-by: ulysses-you <ulyssesyou18@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit d1cf8ff)
kazuyukitanimura
pushed a commit
to kazuyukitanimura/spark
that referenced
this pull request
Aug 10, 2022
…h PrunePartitionsFastFallback ### What changes were proposed in this pull request? Allow `Cast` during `prunePartitionsFastFallback` if it actually does not require the timezone. The original PR apache#34431 ### Why are the changes needed? Make `prunePartitionsFastFallback` work with more cases. For example, one partition column data type is `StringType` but the query with the partition predicate using `IntegerType` ```sql CREATE TABLE t(c int) PARTITIONED BY(p string); SELECT * FROM t WHERE p = 20210101; ``` ### Does this PR introduce _any_ user-facing change? no, not released and this pr itself just affects the perf. ### How was this patch tested? Add some test for `Cast` who need or does not need time zone. Closes apache#34981 from ulysses-you/SPARK-35437-FOLLOWUP. Authored-by: ulysses-you <ulyssesyou18@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Allow
CastduringprunePartitionsFastFallbackif it actually does not require the timezone.The original PR #34431
Why are the changes needed?
Make
prunePartitionsFastFallbackwork with more cases.For example, one partition column data type is
StringTypebut the query with the partition predicate usingIntegerTypeDoes this PR introduce any user-facing change?
no, not released and this pr itself just affects the perf.
How was this patch tested?
Add some test for
Castwho need or does not need time zone.