Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-37496][SQL][FOLLOWUP] DataFrameWriter.saveAsTable should take write options in CTAS and RTAS #34997

Closed
wants to merge 1 commit into from

Conversation

huaxingao
Copy link
Contributor

What changes were proposed in this pull request?

DataFrameWriter.saveAsTable should pass extraOptions.toMap as the write options in CTAS and RTAS

Why are the changes needed?

bug fixing
please see #34754 (comment) #34667 (comment)

Does this PR introduce any user-facing change?

no

How was this patch tested?

new test

@github-actions github-actions bot added the SQL label Dec 23, 2021
@SparkQA
Copy link

SparkQA commented Dec 23, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50987/

@SparkQA
Copy link

SparkQA commented Dec 23, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50987/

@SparkQA
Copy link

SparkQA commented Dec 23, 2021

Test build #146511 has finished for PR 34997 at commit ab9ffd1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@huaxingao
Copy link
Contributor Author

cc @cloud-fan

@cloud-fan
Copy link
Contributor

The GA failure is unrelated, merging to master, thanks!

@cloud-fan cloud-fan closed this in 6c69262 Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants