[SPARK-37756][PYTHON] Enable matplotlib test for pandas API on Spark #35036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Dec 28, 2021
dongjoon-hyun
approved these changes
Dec 28, 2021
| @@ -330,6 +330,9 @@ jobs: | |||
| # TODO(SPARK-36361): Install coverage in Python 3.9 and PyPy 3 in the base image | |||
| python3.9 -m pip install coverage | |||
| pypy3 -m pip install coverage | |||
| # TODO(SPARK-37761): Install matplotlib in Python 3.9 and PyPy 3 in the base image | |||
There was a problem hiding this comment.
Ack. Thank you for filing a JIRA.
Sure, just added before/after test log to the PR description |
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to install
matplotlibfor Python 3.9 in our base image, to enablematplotlibtest for pandas API on Spark.Before
After
Why are the changes needed?
Currently, some tests are skipped due to lack of
matplotlibinstalled as below:So, we'd better to enable this to improve the test coverage.
Does this PR introduce any user-facing change?
No, it's test only.
How was this patch tested?
The existing tests are should be passed.