Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-37818][DOCS] Add option in the description document for show create table #35107

Closed
wants to merge 2 commits into from
Closed

[SPARK-37818][DOCS] Add option in the description document for show create table #35107

wants to merge 2 commits into from

Conversation

Peng-Lei
Copy link
Contributor

@Peng-Lei Peng-Lei commented Jan 5, 2022 •
edited

What changes were proposed in this pull request?

Add options in the description document for SHOW CREATE TABLE command.
1
2

Why are the changes needed?

#discussion

Does this PR introduce any user-facing change?

No

How was this patch tested?

SKIP_API=1 SKIP_RDOC=1 SKIP_PYTHONDOC=1 SKIP_SCALADOC=1 bundle exec jekyll build

@github-actions github-actions bot added the DOCS label Jan 5, 2022
@Peng-Lei Peng-Lei mentioned this pull request Jan 5, 2022
Closed
huaxingao
huaxingao reviewed Jan 5, 2022
View reviewed changes
docs/sql-ref-syntax-aux-show-create-table.md Outdated
@@ -37,6 +37,10 @@ SHOW CREATE TABLE table_identifier

**Syntax:** `[ database_name. ] table_name`

* **AS SERDE**

Just for generating Hive DDL for a Hive SerDe table.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Maybe Generates DDL for a Hive SerDe table to be parallel with Specifies a table or view name...?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Maybe Generates DDL for a Hive SerDe table to be parallel with Specifies a table or view name...?

Generates DDL for a Hive SerDe table begin with 4 space, it is same with Specifies a table or view name...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the confusion, I am not talking about spaces. I mean using "Generates" instead of "Just for generating"

@HyukjinKwon HyukjinKwon changed the title [SPARK-37818][DOCS] add option in the description document for show create table [SPARK-37818][DOCS] Add option in the description document for show create table Jan 6, 2022
@github-actions github-actions bot added the SQL label Jan 6, 2022
gengliangwang
gengliangwang reviewed Jan 6, 2022
View reviewed changes
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala Outdated
@@ -1952,6 +1952,22 @@ class DataSourceV2SQLSuite
}
}

test("xxx") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this test case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. remove it.

gengliangwang
gengliangwang reviewed Jan 6, 2022
View reviewed changes
docs/sql-ref-syntax-aux-show-create-table.md
@@ -26,7 +26,7 @@ license: |
### Syntax

```sql
SHOW CREATE TABLE table_identifier
SHOW CREATE TABLE table_identifier [ AS SERDE ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding a new example with AS SERDE

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I will do it.

@gengliangwang
Copy link
Member

@Peng-Lei could you post a screenshot of the new doc in the PR description?

@Peng-Lei
Copy link
Contributor Author

@Peng-Lei could you post a screenshot of the new doc in the PR description?

done. Thank you very much @gengliangwang

@gengliangwang
Copy link
Member

Thanks, merging to master/3.2

gengliangwang pushed a commit that referenced this pull request Jan 10, 2022
@Peng-Lei @gengliangwang
[SPARK-37818][DOCS] Add option in the description document for show c…
385b34d 
…reate table

### What changes were proposed in this pull request?

Add options in the description document for `SHOW CREATE TABLE ` command.
<img width="767" alt="1" src="https://user-images.githubusercontent.com/41178002/148747443-ecd6586f-e4c4-4ae4-8ea5-969896b7d416.png">
<img width="758" alt="2" src="https://user-images.githubusercontent.com/41178002/148747457-873bc0c3-08fa-4d31-89e7-b44440372462.png">

### Why are the changes needed?
[#discussion](#34719 (comment))

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
SKIP_API=1 SKIP_RDOC=1 SKIP_PYTHONDOC=1 SKIP_SCALADOC=1 bundle exec jekyll build

Closes #35107 from Peng-Lei/SPARK-37818.

Authored-by: PengLei <peng.8lei@gmail.com>
Signed-off-by: Gengliang Wang <gengliang@apache.org>
(cherry picked from commit 2f70e4f)
Signed-off-by: Gengliang Wang <gengliang@apache.org>
dchvn pushed a commit to dchvn/spark that referenced this pull request Jan 19, 2022
@Peng-Lei @dchvn
[SPARK-37818][DOCS] Add option in the description document for show c…
a7ad9ac 
…reate table

### What changes were proposed in this pull request?

Add options in the description document for `SHOW CREATE TABLE ` command.
<img width="767" alt="1" src="https://user-images.githubusercontent.com/41178002/148747443-ecd6586f-e4c4-4ae4-8ea5-969896b7d416.png">
<img width="758" alt="2" src="https://user-images.githubusercontent.com/41178002/148747457-873bc0c3-08fa-4d31-89e7-b44440372462.png">

### Why are the changes needed?
[#discussion](apache#34719 (comment))

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
SKIP_API=1 SKIP_RDOC=1 SKIP_PYTHONDOC=1 SKIP_SCALADOC=1 bundle exec jekyll build

Closes apache#35107 from Peng-Lei/SPARK-37818.

Authored-by: PengLei <peng.8lei@gmail.com>
Signed-off-by: Gengliang Wang <gengliang@apache.org>
catalinii pushed a commit to lyft/spark that referenced this pull request Feb 22, 2022
@Peng-Lei
[SPARK-37818][DOCS] Add option in the description document for show c…
99db039 
…reate table

### What changes were proposed in this pull request?

Add options in the description document for `SHOW CREATE TABLE ` command.
<img width="767" alt="1" src="https://user-images.githubusercontent.com/41178002/148747443-ecd6586f-e4c4-4ae4-8ea5-969896b7d416.png">
<img width="758" alt="2" src="https://user-images.githubusercontent.com/41178002/148747457-873bc0c3-08fa-4d31-89e7-b44440372462.png">

### Why are the changes needed?
[#discussion](apache#34719 (comment))

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
SKIP_API=1 SKIP_RDOC=1 SKIP_PYTHONDOC=1 SKIP_SCALADOC=1 bundle exec jekyll build

Closes apache#35107 from Peng-Lei/SPARK-37818.

Authored-by: PengLei <peng.8lei@gmail.com>
Signed-off-by: Gengliang Wang <gengliang@apache.org>
(cherry picked from commit 2f70e4f)
Signed-off-by: Gengliang Wang <gengliang@apache.org>
catalinii pushed a commit to lyft/spark that referenced this pull request Mar 4, 2022
@Peng-Lei @catalinii
[SPARK-37818][DOCS] Add option in the description document for show c…
81039a9 
…reate table

### What changes were proposed in this pull request?

Add options in the description document for `SHOW CREATE TABLE ` command.
<img width="767" alt="1" src="https://user-images.githubusercontent.com/41178002/148747443-ecd6586f-e4c4-4ae4-8ea5-969896b7d416.png">
<img width="758" alt="2" src="https://user-images.githubusercontent.com/41178002/148747457-873bc0c3-08fa-4d31-89e7-b44440372462.png">

### Why are the changes needed?
[#discussion](apache#34719 (comment))

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
SKIP_API=1 SKIP_RDOC=1 SKIP_PYTHONDOC=1 SKIP_SCALADOC=1 bundle exec jekyll build

Closes apache#35107 from Peng-Lei/SPARK-37818.

Authored-by: PengLei <peng.8lei@gmail.com>
Signed-off-by: Gengliang Wang <gengliang@apache.org>
(cherry picked from commit 2f70e4f)
Signed-off-by: Gengliang Wang <gengliang@apache.org>
kazuyukitanimura pushed a commit to kazuyukitanimura/spark that referenced this pull request Aug 10, 2022
@Peng-Lei @dongjoon-hyun
[SPARK-37818][DOCS] Add option in the description document for show c…
cb1867d 
…reate table

### What changes were proposed in this pull request?

Add options in the description document for `SHOW CREATE TABLE ` command.
<img width="767" alt="1" src="https://user-images.githubusercontent.com/41178002/148747443-ecd6586f-e4c4-4ae4-8ea5-969896b7d416.png">
<img width="758" alt="2" src="https://user-images.githubusercontent.com/41178002/148747457-873bc0c3-08fa-4d31-89e7-b44440372462.png">

### Why are the changes needed?
[#discussion](apache#34719 (comment))

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
SKIP_API=1 SKIP_RDOC=1 SKIP_PYTHONDOC=1 SKIP_SCALADOC=1 bundle exec jekyll build

Closes apache#35107 from Peng-Lei/SPARK-37818.

Authored-by: PengLei <peng.8lei@gmail.com>
Signed-off-by: Gengliang Wang <gengliang@apache.org>
(cherry picked from commit 2f70e4f)
Signed-off-by: Gengliang Wang <gengliang@apache.org>
(cherry picked from commit 385b34d)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huaxingao huaxingao huaxingao approved these changes

@gengliangwang gengliangwang gengliangwang approved these changes

Assignees
No one assigned
Labels
DOCS SQL
Projects
None yet
Milestone
No milestone
3 participants
@Peng-Lei @gengliangwang @huaxingao