[SPARK-37802][SQL][3.2] Composite field name should work with Aggregate push down #35125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
approved these changes
Jan 7, 2022
|
Thanks @dongjoon-hyun |
|
Also cc @cloud-fan |
cloud-fan
approved these changes
Jan 7, 2022
huaxingao
added a commit
that referenced
this pull request
Jan 7, 2022
…te push down
### What changes were proposed in this pull request?
Currently, composite filed name such as dept id doesn't work with aggregate push down
```
sql("SELECT COUNT(`dept id`) FROM h2.test.dept")
org.apache.spark.sql.catalyst.parser.ParseException:
extraneous input 'id' expecting <EOF>(line 1, pos 5)
== SQL ==
dept id
-----^^^
at org.apache.spark.sql.catalyst.parser.ParseException.withCommand(ParseDriver.scala:271)
at org.apache.spark.sql.catalyst.parser.AbstractSqlParser.parse(ParseDriver.scala:132)
at org.apache.spark.sql.catalyst.parser.AbstractSqlParser.parseMultipartIdentifier(ParseDriver.scala:63)
at org.apache.spark.sql.connector.expressions.LogicalExpressions$.parseReference(expressions.scala:39)
at org.apache.spark.sql.connector.expressions.FieldReference$.apply(expressions.scala:365)
at org.apache.spark.sql.execution.datasources.DataSourceStrategy$.translateAggregate(DataSourceStrategy.scala:717)
at org.apache.spark.sql.execution.datasources.v2.PushDownUtils$.$anonfun$pushAggregates$1(PushDownUtils.scala:125)
at scala.collection.immutable.List.flatMap(List.scala:366)
at org.apache.spark.sql.execution.datasources.v2.PushDownUtils$.pushAggregates(PushDownUtils.scala:125)
```
## Why are the changes needed?
bug fixing
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
New test
Closes #35125 from huaxingao/backport.
Authored-by: Huaxin Gao <huaxin_gao@apple.com>
Signed-off-by: Huaxin Gao <huaxin_gao@apple.com>
|
Merged to 3.2. Thanks @cloud-fan @dongjoon-hyun |
catalinii
pushed a commit
to lyft/spark
that referenced
this pull request
Feb 22, 2022
…te push down
### What changes were proposed in this pull request?
Currently, composite filed name such as dept id doesn't work with aggregate push down
```
sql("SELECT COUNT(`dept id`) FROM h2.test.dept")
org.apache.spark.sql.catalyst.parser.ParseException:
extraneous input 'id' expecting <EOF>(line 1, pos 5)
== SQL ==
dept id
-----^^^
at org.apache.spark.sql.catalyst.parser.ParseException.withCommand(ParseDriver.scala:271)
at org.apache.spark.sql.catalyst.parser.AbstractSqlParser.parse(ParseDriver.scala:132)
at org.apache.spark.sql.catalyst.parser.AbstractSqlParser.parseMultipartIdentifier(ParseDriver.scala:63)
at org.apache.spark.sql.connector.expressions.LogicalExpressions$.parseReference(expressions.scala:39)
at org.apache.spark.sql.connector.expressions.FieldReference$.apply(expressions.scala:365)
at org.apache.spark.sql.execution.datasources.DataSourceStrategy$.translateAggregate(DataSourceStrategy.scala:717)
at org.apache.spark.sql.execution.datasources.v2.PushDownUtils$.$anonfun$pushAggregates$1(PushDownUtils.scala:125)
at scala.collection.immutable.List.flatMap(List.scala:366)
at org.apache.spark.sql.execution.datasources.v2.PushDownUtils$.pushAggregates(PushDownUtils.scala:125)
```
## Why are the changes needed?
bug fixing
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
New test
Closes apache#35125 from huaxingao/backport.
Authored-by: Huaxin Gao <huaxin_gao@apple.com>
Signed-off-by: Huaxin Gao <huaxin_gao@apple.com>
catalinii
pushed a commit
to lyft/spark
that referenced
this pull request
Mar 4, 2022
…te push down
### What changes were proposed in this pull request?
Currently, composite filed name such as dept id doesn't work with aggregate push down
```
sql("SELECT COUNT(`dept id`) FROM h2.test.dept")
org.apache.spark.sql.catalyst.parser.ParseException:
extraneous input 'id' expecting <EOF>(line 1, pos 5)
== SQL ==
dept id
-----^^^
at org.apache.spark.sql.catalyst.parser.ParseException.withCommand(ParseDriver.scala:271)
at org.apache.spark.sql.catalyst.parser.AbstractSqlParser.parse(ParseDriver.scala:132)
at org.apache.spark.sql.catalyst.parser.AbstractSqlParser.parseMultipartIdentifier(ParseDriver.scala:63)
at org.apache.spark.sql.connector.expressions.LogicalExpressions$.parseReference(expressions.scala:39)
at org.apache.spark.sql.connector.expressions.FieldReference$.apply(expressions.scala:365)
at org.apache.spark.sql.execution.datasources.DataSourceStrategy$.translateAggregate(DataSourceStrategy.scala:717)
at org.apache.spark.sql.execution.datasources.v2.PushDownUtils$.$anonfun$pushAggregates$1(PushDownUtils.scala:125)
at scala.collection.immutable.List.flatMap(List.scala:366)
at org.apache.spark.sql.execution.datasources.v2.PushDownUtils$.pushAggregates(PushDownUtils.scala:125)
```
## Why are the changes needed?
bug fixing
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
New test
Closes apache#35125 from huaxingao/backport.
Authored-by: Huaxin Gao <huaxin_gao@apple.com>
Signed-off-by: Huaxin Gao <huaxin_gao@apple.com>
kazuyukitanimura
pushed a commit
to kazuyukitanimura/spark
that referenced
this pull request
Aug 10, 2022
…te push down
### What changes were proposed in this pull request?
Currently, composite filed name such as dept id doesn't work with aggregate push down
```
sql("SELECT COUNT(`dept id`) FROM h2.test.dept")
org.apache.spark.sql.catalyst.parser.ParseException:
extraneous input 'id' expecting <EOF>(line 1, pos 5)
== SQL ==
dept id
-----^^^
at org.apache.spark.sql.catalyst.parser.ParseException.withCommand(ParseDriver.scala:271)
at org.apache.spark.sql.catalyst.parser.AbstractSqlParser.parse(ParseDriver.scala:132)
at org.apache.spark.sql.catalyst.parser.AbstractSqlParser.parseMultipartIdentifier(ParseDriver.scala:63)
at org.apache.spark.sql.connector.expressions.LogicalExpressions$.parseReference(expressions.scala:39)
at org.apache.spark.sql.connector.expressions.FieldReference$.apply(expressions.scala:365)
at org.apache.spark.sql.execution.datasources.DataSourceStrategy$.translateAggregate(DataSourceStrategy.scala:717)
at org.apache.spark.sql.execution.datasources.v2.PushDownUtils$.$anonfun$pushAggregates$1(PushDownUtils.scala:125)
at scala.collection.immutable.List.flatMap(List.scala:366)
at org.apache.spark.sql.execution.datasources.v2.PushDownUtils$.pushAggregates(PushDownUtils.scala:125)
```
## Why are the changes needed?
bug fixing
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
New test
Closes apache#35125 from huaxingao/backport.
Authored-by: Huaxin Gao <huaxin_gao@apple.com>
Signed-off-by: Huaxin Gao <huaxin_gao@apple.com>
(cherry picked from commit 4b5d2d7)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, composite filed name such as dept id doesn't work with aggregate push down
Why are the changes needed?
bug fixing
Does this PR introduce any user-facing change?
No
How was this patch tested?
New test