[SPARK-37924][SQL] Sort table properties by key in SHOW CREATE TABLE on VIEW (v1) #35222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
yaooqinn
approved these changes
Jan 17, 2022
|
All tests passed at https://github.com/HyukjinKwon/spark/runs/4835259017. Merged to master. |
|
Thanks guys! |
|
late LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is a sort of a followup of #34719. It added a test but it is flaky due to the order of
TABLPROPERTIESinSHOW CREATE TALBEonVIEWin v1 code path.This PR proposes to have a deterministic order by sorting the table properties in the show command. This is already being sorted in v2 (see
ShowCreateTableExec).Why are the changes needed?
To have the deterministic order, and fix the flaky test.
Does this PR introduce any user-facing change?
Virtually no. It might affect the order of TABLEPROPERTIES in
SHOW TABLE's output onVIEWwhen users are rely onHow was this patch tested?
Fixed the flaky unittest to explicitly test the order.