[SPARK-37933][SQL] Change the traversal method of V2ScanRelationPushDown push down rules #35242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
approved these changes
Jan 18, 2022
|
I'll leave this PR to @cloud-fan . |
HyukjinKwon
changed the title
HyukjinKwon
reviewed
Jan 18, 2022
| @@ -222,7 +231,7 @@ object V2ScanRelationPushDown extends Rule[LogicalPlan] with PredicateHelper { | |||
| Cast(aggAttribute, aggDataType) | |||
| } | |||
|
|
|||
| def applyColumnPruning(plan: LogicalPlan): LogicalPlan = plan.transform { | |||
| def pushDownColumn(plan: LogicalPlan): LogicalPlan = plan.transform { | |||
There was a problem hiding this comment.
I also think pruneColumns or the original name applyColumnPruning might be better.
There was a problem hiding this comment.
pruneColumns sounds good to me, thanks.
HyukjinKwon
reviewed
Jan 18, 2022
| @@ -308,7 +317,7 @@ object V2ScanRelationPushDown extends Rule[LogicalPlan] with PredicateHelper { | |||
| case other => other | |||
| } | |||
|
|
|||
| def applyLimit(plan: LogicalPlan): LogicalPlan = plan.transform { | |||
| def pushDownLimit(plan: LogicalPlan): LogicalPlan = plan.transform { | |||
There was a problem hiding this comment.
the name pushDownLimit is same as pushDownLimit above. Can we use a different name or at least add some docs?
There was a problem hiding this comment.
Hm, maybe pushdownLimits is better.
HyukjinKwon
approved these changes
Jan 18, 2022
huaxingao
approved these changes
Jan 19, 2022
HyukjinKwon
reviewed
Jan 19, 2022
...re/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2ScanRelationPushDown.scala
Outdated
Show resolved
Hide resolved
cloud-fan
approved these changes
Jan 19, 2022
|
Merged to master. |
|
Thanks you all, guys |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr is trying to change the traversal method of V2ScanRelationPushDown push down rules , which is more readable and easier to extend and add new rules.
Does this PR introduce any user-facing change?
No
How was this patch tested?
origin tests