[SPARK-37533][FOLLOWUP] Remove useless code in Analyzer and TryEvalSuite #35260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gengliangwang
commented
Jan 20, 2022
| @@ -1879,9 +1879,6 @@ class Analyzer(override val catalogManager: CatalogManager) | |||
| }} | |||
| } | |||
|
|
|||
| // Group by alias is not allowed in ANSI mode. | |||
| private def allowGroupByAlias: Boolean = conf.groupByAliases && !conf.ansiEnabled | |||
There was a problem hiding this comment.
Somehow this one is missed in 8bfb4f1e72.
gengliangwang
commented
Jan 20, 2022
| @@ -45,28 +45,4 @@ class TryEvalSuite extends SparkFunSuite with ExpressionEvalHelper { | |||
| checkEvaluation(input, expected) | |||
| } | |||
| } | |||
|
|
|||
| test("try_element_at: array") { | |||
There was a problem hiding this comment.
try_element_at doesn't rely on TryEval after #34833
cloud-fan
approved these changes
Jan 20, 2022
dongjoon-hyun
changed the title
dongjoon-hyun
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove useless code in Analyzer and TryEvalSuite
Why are the changes needed?
Code clean up and avoid confusion.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing UT