[SPARK-37978][SHUFFLE] Remove the unnecessary ChunkFetchFailureException class

[weixiuli]

What changes were proposed in this pull request?

Remove the unnecessary ChunkFetchFailureException to clean up the code.

Why are the changes needed?

The ChunkFetchFailureException is unnecessary and can be replaced by RuntimeException.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Passed CI is enough.

[dongjoon-hyun]

First, may I ask why do you want to remove this? It just gave us more information.

The ChunkFetchFailureException is unnecessary and can be replaced by RuntimeException.

Second, are you sure about removal of this public class without any deprecation process?

[weixiuli]

First, may I ask why do you want to remove this? It just gave us more information.

The message of RuntimeException is enough for us，we just reference to exception handling for RpcFailure/StreamFailure .

Second, are you sure about removal of this public class without any deprecation process?

Yes, the class is only used here.

@dongjoon-hyun

[dongjoon-hyun]

It seems that you are ignoring the downstream or user codes which might catch ChunkFetchFailureException. This PR will lead a compilation error or ClassNotFound error in Apache Spark 3.3 in those downstream code. It could be considered as a regression in the user perspective.

Yes, the class is only used here.

In principle, Apache Spark has a deprecation process for the all user facing changes to avoid any surprise in the production. Please take a look at the community policy.

• https://spark.apache.org/versioning-policy.html

FYI, historically, Apache Spark community tried to clean up many things at 3.0 and later recovered back many things to avoid those kind of hassle. For this one, I'm not sure about the benefit. Is this worth of the removal cost?

[weixiuli]

Ok, i see. Thank you very much @dongjoon-hyun

[AmplabJenkins]

Can one of the admins verify this patch?

[dongjoon-hyun]

Let me close this PR first. We can continue the discussion about this topic in this PR or JIRA, and reopen this if needed.