[SPARK-37984][SHUFFLE] Avoid calculating all outstanding requests to improve performance. #35276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…improve performance.
|
Friendly cc @srowen @dongjoon-hyun |
|
Does this change performance much? it's still getting the size of every collection. isEmpty might make it a little more optimal. OK either way just might not make any difference |
Done. |
|
Can one of the admins verify this patch? |
srowen
reviewed
Jan 23, 2022
No, I checked again and confirmed that the PR included all of them. @srowen |
|
Merged to master |
|
Thanks @srowen |
FMX
pushed a commit
to apache/celeborn
that referenced
this pull request
Feb 23, 2024
… performance ### What changes were proposed in this pull request? Refer [SPARK-37894](https://issues.apache.org/jira/browse/SPARK-37984)/ apache/spark#35276 Avoid calculating all outstanding requests to improve performance ### Why are the changes needed? Ditto. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Not needed. Closes #2319 from turboFei/SPARK-37984_backport. Authored-by: Fei Wang <fwang12@ebay.com> Signed-off-by: mingji <fengmingxiao.fmx@alibaba-inc.com>
FMX
pushed a commit
to apache/celeborn
that referenced
this pull request
Feb 23, 2024
… performance ### What changes were proposed in this pull request? Refer [SPARK-37894](https://issues.apache.org/jira/browse/SPARK-37984)/ apache/spark#35276 Avoid calculating all outstanding requests to improve performance ### Why are the changes needed? Ditto. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Not needed. Closes #2319 from turboFei/SPARK-37984_backport. Authored-by: Fei Wang <fwang12@ebay.com> Signed-off-by: mingji <fengmingxiao.fmx@alibaba-inc.com> (cherry picked from commit 621a719) Signed-off-by: mingji <fengmingxiao.fmx@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Avoid calculating all outstanding requests to improve performance.
Why are the changes needed?
Follow the comment (#34711 (review)) , we can implement a "has outstanding requests" method in the response handler that doesn't even need to get a count，let's do this with PR.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Exist unittests.