Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-4397][Core] Cleanup 'import SparkContext._' in core #3530

Closed
wants to merge 1 commit into from
Closed

[SPARK-4397][Core] Cleanup 'import SparkContext._' in core #3530

wants to merge 1 commit into from

Conversation

zsxwing
Copy link
Member

@zsxwing zsxwing commented Dec 1, 2014

This PR cleans up import SparkContext._ in core for SPARK-4397(#3262) to prove it really works well.

@SparkQA
Copy link

SparkQA commented Dec 1, 2014

Test build #23977 has started for PR 3530 at commit 04e2273.

  • This patch merges cleanly.

@JoshRosen
Copy link
Contributor

This is a really important fix, actually, since we ran into problems with IntelliJ's automatic import cleanup removing these: if we perform this import cleanup incrementally as part of other patches, then those patches will introduce build-breaks if they're cherry-picked into pre-1.2 versions of Spark. As a result, it's much better to do all of this cleanup in one pass, as you've done here.

+1.

@SparkQA
Copy link

SparkQA commented Dec 1, 2014

Test build #23977 has finished for PR 3530 at commit 04e2273.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23977/
Test PASSed.

@rxin
Copy link
Contributor

rxin commented Dec 2, 2014

Thanks. Merging in master.

@asfgit asfgit closed this in 6dfe38a Dec 2, 2014
@zsxwing zsxwing deleted the SPARK-4397-cleanup branch December 2, 2014 08:20
@zzcclp
Copy link
Contributor

zzcclp commented Dec 2, 2014

Whether this PR will be merged into the branch 1.2?

@zsxwing
Copy link
Member Author

zsxwing commented Dec 2, 2014

No. This is for SPARK-4397(#3262) and #3262 wasn't merged to branch 1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants