[SPARK-38022][K8S][TESTS] Use relativePath for K8s remote file test in BasicTestsSuite
#35318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n BasicTestsSuite
Yikun
approved these changes
Jan 25, 2022
There was a problem hiding this comment.
Yep, the file path should be trim the spark home prefix like: resource-managers/kubernetes/integration-tests/target/scala-2.12/test-classes/pagerank_data.txt
It also passed in my env with k8s v1.23.2 Platform:"linux/amd64".
[info] - Run SparkRemoteFileTest using a remote data file (12 seconds, 701 milliseconds)
LGTM, thanks!
|
Thank you, @Yikun . This is a part of recovering K8s integration suite which has been broken for a while. |
|
Could you review this please, @viirya ? |
viirya
approved these changes
Jan 25, 2022
|
Thank you so much! |
|
lgtm |
dongjoon-hyun
added a commit
that referenced
this pull request
Jan 25, 2022
…n `BasicTestsSuite` ### What changes were proposed in this pull request? This PR aims to use `relativePath` for K8s remote file test in `BasicTestsSuite`. ### Why are the changes needed? To make `Run SparkRemoteFileTest using a remote data file` test pass. **BEFORE** ``` $ build/sbt -Pkubernetes -Pkubernetes-integration-tests -Dspark.kubernetes.test.dockerFile=resource-managers/kubernetes/docker/src/main/dockerfiles/spark/Dockerfile.java17 -Dtest.exclude.tags=minikube,r "kubernetes-integration-tests/test" ... [info] KubernetesSuite: ... [info] - Run SparkRemoteFileTest using a remote data file *** FAILED *** (3 minutes, 3 seconds) [info] The code passed to eventually never returned normally. Attempted 190 times over 3.012265011116667 minutes. Last failure message: false was not true. (KubernetesSuite.scala:452) ... ``` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? ``` $ build/sbt -Pkubernetes -Pkubernetes-integration-tests -Dspark.kubernetes.test.dockerFile=resource-managers/kubernetes/docker/src/main/dockerfiles/spark/Dockerfile.java17 -Dtest.exclude.tags=minikube,r "kubernetes-integration-tests/test" ... [info] KubernetesSuite: ... [info] - Run SparkRemoteFileTest using a remote data file (8 seconds, 608 milliseconds) ... ``` Closes #35318 from dongjoon-hyun/SPARK-38022. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 2773228) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
senthh
pushed a commit
to senthh/spark-1
that referenced
this pull request
Feb 3, 2022
…n `BasicTestsSuite` ### What changes were proposed in this pull request? This PR aims to use `relativePath` for K8s remote file test in `BasicTestsSuite`. ### Why are the changes needed? To make `Run SparkRemoteFileTest using a remote data file` test pass. **BEFORE** ``` $ build/sbt -Pkubernetes -Pkubernetes-integration-tests -Dspark.kubernetes.test.dockerFile=resource-managers/kubernetes/docker/src/main/dockerfiles/spark/Dockerfile.java17 -Dtest.exclude.tags=minikube,r "kubernetes-integration-tests/test" ... [info] KubernetesSuite: ... [info] - Run SparkRemoteFileTest using a remote data file *** FAILED *** (3 minutes, 3 seconds) [info] The code passed to eventually never returned normally. Attempted 190 times over 3.012265011116667 minutes. Last failure message: false was not true. (KubernetesSuite.scala:452) ... ``` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? ``` $ build/sbt -Pkubernetes -Pkubernetes-integration-tests -Dspark.kubernetes.test.dockerFile=resource-managers/kubernetes/docker/src/main/dockerfiles/spark/Dockerfile.java17 -Dtest.exclude.tags=minikube,r "kubernetes-integration-tests/test" ... [info] KubernetesSuite: ... [info] - Run SparkRemoteFileTest using a remote data file (8 seconds, 608 milliseconds) ... ``` Closes apache#35318 from dongjoon-hyun/SPARK-38022. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
kazuyukitanimura
pushed a commit
to kazuyukitanimura/spark
that referenced
this pull request
Aug 10, 2022
…n `BasicTestsSuite` ### What changes were proposed in this pull request? This PR aims to use `relativePath` for K8s remote file test in `BasicTestsSuite`. ### Why are the changes needed? To make `Run SparkRemoteFileTest using a remote data file` test pass. **BEFORE** ``` $ build/sbt -Pkubernetes -Pkubernetes-integration-tests -Dspark.kubernetes.test.dockerFile=resource-managers/kubernetes/docker/src/main/dockerfiles/spark/Dockerfile.java17 -Dtest.exclude.tags=minikube,r "kubernetes-integration-tests/test" ... [info] KubernetesSuite: ... [info] - Run SparkRemoteFileTest using a remote data file *** FAILED *** (3 minutes, 3 seconds) [info] The code passed to eventually never returned normally. Attempted 190 times over 3.012265011116667 minutes. Last failure message: false was not true. (KubernetesSuite.scala:452) ... ``` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? ``` $ build/sbt -Pkubernetes -Pkubernetes-integration-tests -Dspark.kubernetes.test.dockerFile=resource-managers/kubernetes/docker/src/main/dockerfiles/spark/Dockerfile.java17 -Dtest.exclude.tags=minikube,r "kubernetes-integration-tests/test" ... [info] KubernetesSuite: ... [info] - Run SparkRemoteFileTest using a remote data file (8 seconds, 608 milliseconds) ... ``` Closes apache#35318 from dongjoon-hyun/SPARK-38022. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 2773228) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to use
relativePathfor K8s remote file test inBasicTestsSuite.Why are the changes needed?
To make
Run SparkRemoteFileTest using a remote data filetest pass.BEFORE
Does this PR introduce any user-facing change?
No.
How was this patch tested?