[SPARK-38036][SQL][TESTS] Refactor VersionsSuite to HiveClientSuite and make it a subclass of HiveVersionSuite
#35335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
changed the title
VersionsSuite to HiveClientSuite and make it a subclass of HiveVersionSuiteVersionsSuite to HiveClientSuite and make it a subclass of HiveVersionSuite
LuciferYang
commented
Jan 27, 2022
| private var versionSpark: TestHiveVersion = null | ||
|
|
||
| versions.foreach { version => | ||
| test(s"$version: create client") { |
There was a problem hiding this comment.
The test cases in versions.foreach have been moved to HiveClientSuite.scala
LuciferYang
commented
Jan 27, 2022
| // Since Hive 3.0, HIVE-19310 skipped `ensureDbInit` if `hive.in.test=false`. | ||
| hadoopConf.set("hive.in.test", "true") | ||
| // Since HIVE-17626(Hive 3.0.0), need to set hive.query.reexecution.enabled=false. | ||
| hadoopConf.set("hive.query.reexecution.enabled", "false") |
There was a problem hiding this comment.
hadoopConf.set("hive.query.reexecution.enabled", "false") move to HiveVersionSuite.scala as default configuration.
LuciferYang
commented
Jan 27, 2022
| } | ||
| } | ||
|
|
||
| test("success sanity check") { |
There was a problem hiding this comment.
success sanity check, hadoop configuration preserved, override useless and side-effect hive configurations and failure sanity check move to HiveClientSuites
LuciferYang
commented
Jan 27, 2022
| } | ||
| } | ||
|
|
||
| test("create client") { |
There was a problem hiding this comment.
The $version: prefix is removed because the subclass of HiveVersionSuite will print this prefix by default, other cases in this file are similar
cloud-fan
approved these changes
Feb 11, 2022
|
merging to master! |
|
thanks @cloud-fan |
dongjoon-hyun
added a commit
that referenced
this pull request
Apr 1, 2024
### What changes were proposed in this pull request? This PR aims to clean up the removed `VersionsSuite` reference. ### Why are the changes needed? At Apache Spark 3.3.0, `VersionsSuite` is removed via SPARK-38036 . - #35335 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #45800 from dongjoon-hyun/SPARK-47676. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
dongjoon-hyun
added a commit
that referenced
this pull request
Apr 1, 2024
### What changes were proposed in this pull request? This PR aims to clean up the removed `VersionsSuite` reference. ### Why are the changes needed? At Apache Spark 3.3.0, `VersionsSuite` is removed via SPARK-38036 . - #35335 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #45800 from dongjoon-hyun/SPARK-47676. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com> (cherry picked from commit 128f74b) Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
dongjoon-hyun
added a commit
that referenced
this pull request
Apr 1, 2024
### What changes were proposed in this pull request? This PR aims to clean up the removed `VersionsSuite` reference. ### Why are the changes needed? At Apache Spark 3.3.0, `VersionsSuite` is removed via SPARK-38036 . - #35335 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #45800 from dongjoon-hyun/SPARK-47676. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com> (cherry picked from commit 128f74b) Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
There is a TODO in
VersionsSuite:HiveClientSuiteand make it a subclass ofHiveVersionSuitethis pr completed this TODO, the main change as follows:
versions.foreachscope ofVersionsSuitetoHiveClientSuitenestedSuitesfunction inHiveClientSuitesto use each hive version to test the cases inHiveClientSuitesimilar asHiveClientUserNameSuitesandHivePartitionFilteringSuitesHiveClientSuitesWhy are the changes needed?
Make
VersionsSuiteas a subclass ofHiveVersionSuiteto unify the test mode of multi version hiveDoes this PR introduce any user-facing change?
No.
How was this patch tested?
Before
After
The number of test cases is the same, and Suites changed from 2 to 14