-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-38048][K8S][TESTS] Add IntegrationTestBackend.describePods
to support all K8s test backends
#35344
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upport all K8s test backends
dongjoon-hyun
approved these changes
Jan 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Thank you, @williamhyun .
+1, LGTM. Merged to master.
dongjoon-hyun
changed the title
[SPARK-38048][K8S][TESTS] Add IntegrationTestBackend.describePods to support all K8s test backends
[SPARK-38048][K8S][TESTS] Add Jan 28, 2022
IntegrationTestBackend.describePods
to support all K8s test backends
senthh
pushed a commit
to senthh/spark-1
that referenced
this pull request
Feb 3, 2022
…o support all K8s test backends ### What changes were proposed in this pull request? This PR aims to add `IntegrationTestBackend.describePods` to support all K8s test backends ### Why are the changes needed? Currently the docker based K8s tests cannot get the pod information when it fails. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manually. Closes apache#35344 from williamhyun/describePOD. Authored-by: William Hyun <william@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
I tested and backported this test patch to
|
dongjoon-hyun
pushed a commit
that referenced
this pull request
Mar 2, 2022
…o support all K8s test backends ### What changes were proposed in this pull request? This PR aims to add `IntegrationTestBackend.describePods` to support all K8s test backends ### Why are the changes needed? Currently the docker based K8s tests cannot get the pod information when it fails. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manually. Closes #35344 from williamhyun/describePOD. Authored-by: William Hyun <william@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 4f75577) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
kazuyukitanimura
pushed a commit
to kazuyukitanimura/spark
that referenced
this pull request
Aug 10, 2022
…o support all K8s test backends ### What changes were proposed in this pull request? This PR aims to add `IntegrationTestBackend.describePods` to support all K8s test backends ### Why are the changes needed? Currently the docker based K8s tests cannot get the pod information when it fails. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manually. Closes apache#35344 from williamhyun/describePOD. Authored-by: William Hyun <william@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 4f75577) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 79a68be) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to add
IntegrationTestBackend.describePods
to support all K8s test backendsWhy are the changes needed?
Currently the docker based K8s tests cannot get the pod information when it fails.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manually.