[SPARK-38013][SQL][TEST] AQE can change bhj to smj if no extra shuffle introduce #35353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @yaooqinn @cloud-fan @HyukjinKwon if you have time to take a look |
cloud-fan
approved these changes
Jan 28, 2022
| """ | ||
| |SELECT * FROM ( | ||
| | SELECT distinct c1 from t1 | ||
| | )t1 JOIN ( |
There was a problem hiding this comment.
nit. Could you add a space? )t1 -> ) t1?
| | SELECT distinct c1 from t1 | ||
| | )t1 JOIN ( | ||
| | SELECT distinct c1 from t2 | ||
| | )t2 ON t1.c1 = t2.c1 |
|
@dongjoon-hyun thank you, addressed comment |
dongjoon-hyun
approved these changes
Jan 28, 2022
dongjoon-hyun
pushed a commit
that referenced
this pull request
Feb 2, 2022
…e introduce ### What changes were proposed in this pull request? Add a test case in `AdaptiveQueryExecSuite`. ### Why are the changes needed? AQE can change bhj to smj, and it requires two conditions: - no extra shuffle introduce, otherwise the built-in cost evaluator will ban it - AQE does not think the join can be planned as broadcast join. That says the cost statistics in normal planner is not accurate. It's counterintuitive, but it's an expected behavior as AQE designed. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? Pass CI Closes #35353 from ulysses-you/bhj-smj. Authored-by: ulysses-you <ulyssesyou18@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit dc2fd57) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
|
Merged to master/3.2 |
kazuyukitanimura
pushed a commit
to kazuyukitanimura/spark
that referenced
this pull request
Aug 10, 2022
…e introduce ### What changes were proposed in this pull request? Add a test case in `AdaptiveQueryExecSuite`. ### Why are the changes needed? AQE can change bhj to smj, and it requires two conditions: - no extra shuffle introduce, otherwise the built-in cost evaluator will ban it - AQE does not think the join can be planned as broadcast join. That says the cost statistics in normal planner is not accurate. It's counterintuitive, but it's an expected behavior as AQE designed. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? Pass CI Closes apache#35353 from ulysses-you/bhj-smj. Authored-by: ulysses-you <ulyssesyou18@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit dc2fd57) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 6fc9793)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add a test case in
AdaptiveQueryExecSuite.Why are the changes needed?
AQE can change bhj to smj, and it requires two conditions:
It's counterintuitive, but it's an expected behavior as AQE designed.
Does this PR introduce any user-facing change?
no
How was this patch tested?
Pass CI