[SPARK-37943][SQL] Use error classes in the compilation errors of grouping

[SaurabhChawla100]

What changes were proposed in this pull request?

Migrate the following errors in QueryCompilationErrors onto use error classes:
groupingMustWithGroupingSetsOrCubeOrRollupError => UNSUPPORTED_GROUPING_EXPRESSION

Why are the changes needed?

Porting grouping /grouping Id errors to new error framework.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Added the unit test in QueryCompilationErrorsSuite and tested the unit test

[AmplabJenkins]

Can one of the admins verify this patch?

[amaliujia]

Overall looks good. I have only a question for the error message.

cc @amaliujia

[amaliujia]

I am thinking GroupingSets/Cube/Rollup is not easy to understand. Right now I cannot immediately recall what is grouping sets or cube or rollup.

Is it possible to use other way to explain grouping()/grouping_id()? Like they can only be used in syntax a, b, c

[amaliujia]

GroupingSets/Cube/Rollup are actually first class SQL syntax. So saying them in error message should be fine as people can quickly search and then know what GroupingSets/Cube/Rollup is.

[amaliujia]

Seems like we can already pass a parametrized reason here as we know this is sort with grouping?

[SaurabhChawla100]

If I am understanding correctly So the message should be like this

"Sort with grouping()/grouping_id() can only be used with GroupingSets/Cube/Rollup" 
   
instead of 

"grouping()/grouping_id() can only be used with GroupingSets/Cube/Rollup"

Similar case for filter

"Filter with grouping()/grouping_id() can only be used with GroupingSets/Cube/Rollup" 

instead of 

"grouping()/grouping_id() can only be used with GroupingSets/Cube/Rollup"

[SaurabhChawla100]

As per the code val groupingExprs = findGroupingExprs(child) . findGroupingExprs is called from two places

https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala#L733)

and

https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala#L740.

In that case if want to parameterised the error by updating the input param to the method
def findGroupingExprs(plan: LogicalPlan) to def findGroupingExprs(plan: LogicalPlan, parentInfo: String)

So that when throwing the exception we can add the where it failed either in filter or sort.

If this looks fine, I can make that change

[amaliujia]

NVM. Sort with grouping()/grouping_id() can only be used with GroupingSets/Cube/Rollup is not really more helpful.

[MaxGekk]

nit: remove the empty line.

[SaurabhChawla100]

done

[MaxGekk]

Suggested change

	// filter with grouping
	var errMsg = intercept[AnalysisException] {
	df.filter("grouping(CustomerId)=17850")
	.groupBy("CustomerId").agg(Map("Quantity" -> "max"))
	}
	assert(errMsg.message ===
	"grouping()/grouping_id() can only be used with GroupingSets/Cube/Rollup")
	assert(errMsg.errorClass === Some("UNSUPPORTED_GROUPING_EXPRESSION"))
	// filter with grouping_id
	errMsg = intercept[AnalysisException] {
	df.filter("grouping_id(CustomerId)=17850").
	groupBy("CustomerId").agg(Map("Quantity" -> "max"))
	}
	assert(errMsg.errorClass === Some("UNSUPPORTED_GROUPING_EXPRESSION"))
	assert(errMsg.message ===
	"grouping()/grouping_id() can only be used with GroupingSets/Cube/Rollup")
	Seq("grouping", "grouping_id").foreach { grouping =>
	val errMsg = intercept[AnalysisException] {
	df.filter(s"$grouping(CustomerId)=17850")
	.groupBy("CustomerId").agg(Map("Quantity" -> "max"))
	}
	assert(errMsg.message ===
	"grouping()/grouping_id() can only be used with GroupingSets/Cube/Rollup")
	assert(errMsg.errorClass === Some("UNSUPPORTED_GROUPING_EXPRESSION"))
	}

[SaurabhChawla100]

done

[MaxGekk]

Suggested change

	// Sort with grouping
	var errMsg = intercept[AnalysisException] {
	df.sort(grouping("CustomerId"))
	.groupBy("CustomerId").agg(Map("Quantity" -> "max"))
	}
	assert(errMsg.errorClass === Some("UNSUPPORTED_GROUPING_EXPRESSION"))
	assert(errMsg.message ===
	"grouping()/grouping_id() can only be used with GroupingSets/Cube/Rollup")
	// Sort with grouping_id
	errMsg = intercept[AnalysisException] {
	df.sort(grouping_id("CustomerId")).
	groupBy("CustomerId").agg(Map("Quantity" -> "max"))
	}
	assert(errMsg.errorClass === Some("UNSUPPORTED_GROUPING_EXPRESSION"))
	assert(errMsg.message ===
	"grouping()/grouping_id() can only be used with GroupingSets/Cube/Rollup")
	Seq(grouping("CustomerId"), grouping_id("CustomerId")).foreach { grouping =>
	val errMsg = intercept[AnalysisException] {
	df.sort(grouping)
	.groupBy("CustomerId").agg(Map("Quantity" -> "max"))
	}
	assert(errMsg.errorClass === Some("UNSUPPORTED_GROUPING_EXPRESSION"))
	assert(errMsg.message ===
	"grouping()/grouping_id() can only be used with GroupingSets/Cube/Rollup")
	}
	}

[SaurabhChawla100]

done

[MaxGekk]

+1, LGTM. Merging to master.
Thank you, @SaurabhChawla100 and @amaliujia for review.