[SPARK-38100][SQL] Remove unused private method in Decimal
#35392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huaxingao
approved these changes
Feb 3, 2022
huaxingao
pushed a commit
that referenced
this pull request
Feb 3, 2022
### What changes were proposed in this pull request? There is an unused `private` method `overflowException` in `org.apache.spark.sql.types.Decimal`, this method add by SPARK-28741 and the relevant invocations are replaced by `QueryExecutionErrors.castingCauseOverflowError` directly after SPARK-35060. So this pr remove this unused method. ### Why are the changes needed? Remove unused method. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GA Closes #35392 from LuciferYang/SPARK-38100. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: huaxingao <huaxin_gao@apple.com> (cherry picked from commit 7a613ec) Signed-off-by: huaxingao <huaxin_gao@apple.com>
|
Thanks! Merged to master/3.2. |
|
thanks |
kazuyukitanimura
pushed a commit
to kazuyukitanimura/spark
that referenced
this pull request
Aug 10, 2022
### What changes were proposed in this pull request? There is an unused `private` method `overflowException` in `org.apache.spark.sql.types.Decimal`, this method add by SPARK-28741 and the relevant invocations are replaced by `QueryExecutionErrors.castingCauseOverflowError` directly after SPARK-35060. So this pr remove this unused method. ### Why are the changes needed? Remove unused method. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GA Closes apache#35392 from LuciferYang/SPARK-38100. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: huaxingao <huaxin_gao@apple.com> (cherry picked from commit 7a613ec) Signed-off-by: huaxingao <huaxin_gao@apple.com> (cherry picked from commit 4cd3fd3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
There is an unused
privatemethodoverflowExceptioninorg.apache.spark.sql.types.Decimal, this method add by SPARK-28741 and the relevant invocations are replaced byQueryExecutionErrors.castingCauseOverflowErrordirectly after SPARK-35060. So this pr remove this unused method.Why are the changes needed?
Remove unused method.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass GA