[SPARK-37735][K8S][TESTS][FOLLOWUP] Remove casting to KubernetesConf in tests #35413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor simplification: There is no need to cast org.apache.spark.deploy.k8s.KubernetesDriverConf/KubernetesExecutorConf to org.apache.spark.deploy.k8s.KubernetesConf in KubernetesConfSuite Related-to: apache#35015 Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
dongjoon-hyun
changed the title
dongjoon-hyun
approved these changes
Feb 7, 2022
There was a problem hiding this comment.
+1, LGTM. I check that there are no other instances.
$ git grep '.asInstanceOf\[KubernetesConf\].'
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/KubernetesConfSuite.scala: assert(driverConf.asInstanceOf[KubernetesConf].appId === KubernetesTestConf.APP_ID)
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/KubernetesConfSuite.scala: assert(execConf.asInstanceOf[KubernetesConf].appId === KubernetesTestConf.APP_ID)
Merged to master. All K8s tested passed already.
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Minor simplification:
There is no need to cast
org.apache.spark.deploy.k8s.KubernetesDriverConf/KubernetesExecutorConf to org.apache.spark.deploy.k8s.KubernetesConf in KubernetesConfSuite
Related-to: #35015
Why are the changes needed?
Small simplification of the test code.
Does this PR introduce any user-facing change?
No!
How was this patch tested?
Build and test KubernetesConfSuite#test("SPARK-37735: access appId in KubernetesConf") {