[SPARK-37145][K8S][FOLLOWUP] Add note for KubernetesCustom[Driver/Executor]FeatureConfigStep
#35496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
reviewed
Feb 12, 2022
...ain/scala/org/apache/spark/deploy/k8s/features/KubernetesDriverCustomFeatureConfigStep.scala
Outdated
Show resolved
Hide resolved
...ain/scala/org/apache/spark/deploy/k8s/features/KubernetesDriverCustomFeatureConfigStep.scala
Outdated
Show resolved
Hide resolved
...ain/scala/org/apache/spark/deploy/k8s/features/KubernetesDriverCustomFeatureConfigStep.scala
Show resolved
Hide resolved
...ain/scala/org/apache/spark/deploy/k8s/features/KubernetesDriverCustomFeatureConfigStep.scala
Outdated
Show resolved
Hide resolved
|
Looking fine but let me cc @dongjoon-hyun @attilapiros FYI |
attilapiros
reviewed
Feb 13, 2022
...n/scala/org/apache/spark/deploy/k8s/features/KubernetesExecutorCustomFeatureConfigStep.scala
Outdated
Show resolved
Hide resolved
Yikun
changed the title
dongjoon-hyun
changed the title
KubernetesCustom[Driver/Executor]FeatureConfigStep
|
Thank you for pinging me, @HyukjinKwon . |
...ain/scala/org/apache/spark/deploy/k8s/features/KubernetesDriverCustomFeatureConfigStep.scala
Outdated
Show resolved
Hide resolved
...n/scala/org/apache/spark/deploy/k8s/features/KubernetesExecutorCustomFeatureConfigStep.scala
Outdated
Show resolved
Hide resolved
dongjoon-hyun
requested changes
Feb 14, 2022
Maybe |
|
Thanks. That looks better, @Yikun . |
|
Gentle ping, @Yikun . |
|
@dongjoon-hyun addressed! : ) |
dongjoon-hyun
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add note for developers to show how to use
KubernetesDriverCustomFeatureConfigStepandKubernetesExecutorCustomFeatureConfigStep(#35345).Why are the changes needed?
Give an example to show how to use it.
Does this PR introduce any user-facing change?
No, doc only
How was this patch tested?
ci passed