[SPARK-34777][UI] Fix StagePage input size/records not show when records greater than zero #35498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecords greater than zero
|
Can one of the admins verify this patch? |
wangyum
reviewed
Mar 12, 2022
Comment on lines
+407
to
+408
| dataToShow.showInputData = responseBody.inputBytes > 0 || responseBody.inputRecords > 0 ; | ||
| dataToShow.showOutputData = responseBody.outputBytes > 0 || responseBody.outputRecords > 0; |
There was a problem hiding this comment.
This can be easily reproduced by any spark structured streaming job reading from Kafka source.
There was a problem hiding this comment.
@wangyum Any more comments for this?
There was a problem hiding this comment.
Adding responseBody.inputRecords > 0 seems correct. But why do we need to add responseBody.outputRecords > 0?
There was a problem hiding this comment.
if sending message into Kafka, output will have similar bug.
|
cc @HeartSaVioR |
|
@wangyum @HeartSaVioR Could you help take a look? |
wangyum
approved these changes
Aug 30, 2022
wangyum
changed the title
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Determine whether show input/output size and records based on either has value, rather than only size.
Before:
After:
Why are the changes needed?
Stage page UI not show input/output size and records even when records greater than zero. This is common when data source only have records metrics updated.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Manually