Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-4692] [SQL] Support ! boolean logic operator like NOT #3555

Closed
wants to merge 23 commits into from

Conversation

YanTangZhai
Copy link
Contributor

Support ! boolean logic operator like NOT in sql as follows
select * from for_test where !(col1 > col2)

@SparkQA
Copy link

SparkQA commented Dec 2, 2014

Test build #24041 has started for PR 3555 at commit 92242c7.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 2, 2014

Test build #24041 has finished for PR 3555 at commit 92242c7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24041/
Test PASSed.

@marmbrus
Copy link
Contributor

marmbrus commented Dec 2, 2014

Please add a test to HiveQuerySuite.

@SparkQA
Copy link

SparkQA commented Dec 3, 2014

Test build #24070 has started for PR 3555 at commit 74175b4.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 3, 2014

Test build #24070 has finished for PR 3555 at commit 74175b4.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24070/
Test FAILed.

@SparkQA
Copy link

SparkQA commented Dec 3, 2014

Test build #24076 has started for PR 3555 at commit 950b21e.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 3, 2014

Test build #24076 has finished for PR 3555 at commit 950b21e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24076/
Test PASSed.

@marmbrus
Copy link
Contributor

Do other SQL dialects support this? I think we should avoid too much non-standard syntax.

@marmbrus
Copy link
Contributor

How about we switch this to a query test (YanTangZhai#14). otherwise LGTM

@SparkQA
Copy link

SparkQA commented Dec 18, 2014

Test build #24583 has started for PR 3555 at commit 1893956.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 18, 2014

Test build #24583 has finished for PR 3555 at commit 1893956.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24583/
Test PASSed.

@YanTangZhai
Copy link
Contributor Author

@marmbrus Please review again. Thanks.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24698/
Test FAILed.

@liancheng
Copy link
Contributor

Ah, sorry, forgot that the golden answer file name is generated by the MD5 of the query string. Then let's revert the last space change. I think this minor issue doesn't worth the trouble. Sorry for the inconvenience...

@YanTangZhai
Copy link
Contributor Author

@liancheng I will revert the last space change. Thanks for your comment.

@SparkQA
Copy link

SparkQA commented Dec 22, 2014

Test build #24702 has started for PR 3555 at commit 1e1ebb4.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 22, 2014

Test build #24702 has finished for PR 3555 at commit 1e1ebb4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24702/
Test PASSed.

@liancheng
Copy link
Contributor

Thanks for the update, this now LGTM.

@marmbrus
Copy link
Contributor

Hey sorry, this has merge conflicts. Can you merge with master?

@SparkQA
Copy link

SparkQA commented Dec 31, 2014

Test build #24935 has started for PR 3555 at commit 192411d.

  • This patch does not merge cleanly.

@SparkQA
Copy link

SparkQA commented Dec 31, 2014

Test build #24939 has started for PR 3555 at commit 992046e.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 31, 2014

Test build #24940 has started for PR 3555 at commit 1a9f605.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 31, 2014

Test build #24935 has finished for PR 3555 at commit 192411d.

  • This patch passes all tests.
  • This patch does not merge cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24935/
Test PASSed.

@YanTangZhai
Copy link
Contributor Author

@marmbrus I've updated it. Please review again.

@SparkQA
Copy link

SparkQA commented Dec 31, 2014

Test build #24939 has finished for PR 3555 at commit 992046e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24939/
Test PASSed.

@SparkQA
Copy link

SparkQA commented Dec 31, 2014

Test build #24940 has finished for PR 3555 at commit 1a9f605.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24940/
Test PASSed.

@marmbrus
Copy link
Contributor

Thanks! I've merged this to master.

@asfgit asfgit closed this in 0ca51cc Jan 10, 2015
@YanTangZhai YanTangZhai deleted the SPARK-4692 branch January 12, 2015 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants