[SPARK-38241][K8S][TESTS] Close KubernetesClient in K8S integrations tests #35555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
dongjoon-hyun
changed the title
|
BTW, Apache Spark community has a convention to use |
|
Can one of the admins verify this patch? |
Yikun
approved these changes
Feb 21, 2022
There was a problem hiding this comment.
Sorry folks.
This PR has been blocked due to the recent Docker Desktop validation issue.
- f33e371
- bc6eb92
- [SPARK-38272][K8S][TESTS] Use
docker-desktopinstead ofdocker-for-desktopfor Docker K8S IT deployMode and context name #35595 - [SPARK-38244][K8S][BUILD] Upgrade kubernetes-client to 5.12.1 #35596
We've been very careful because of the previous outage.
|
@dongjoon-hyun Thanks, it reasonable for careful at this stage. @martin-g I also tested it in my k8s, it works as expected, but the |
dongjoon-hyun
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Close org.apache.spark.deploy.k8s.integrationtest.backend.IntegrationTestBackend#getKubernetesClient in the
cleanUp()of the backend implementations.Why are the changes needed?
It is a good practice to cleanup resources at the end of the tests, so they do not leak and affect other tests.
Recently I've noticed the following in the output:
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Run the IT tests