[MINOR][DOCS] Fixed closing tags in running-on-kubernetes.md #35561
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
dongjoon-hyun
approved these changes
Feb 18, 2022
There was a problem hiding this comment.
+1, LGTM. Thank you, @zr-msft .
Welcome to the Apache Spark community.
Merged to master.
|
There is a conflict on branch-3.2. You can make a backporting PR against |
zr-msft
pushed a commit
to zr-msft/spark
that referenced
this pull request
Feb 18, 2022
…-kubernetes.md causing rendering issues
dongjoon-hyun
pushed a commit
that referenced
this pull request
Feb 18, 2022
### What changes were proposed in this pull request? Per [feedback](#35561 (comment)) on #35561 from dongjoon-hyun, I'm back porting fixes from `master` to `branch-3.2` since there was a conflict. From original PR: > Several `<code>` elements in running-on-kubernetes.md had typos in their closing tags, causing rendering issues on the HTML site. Example of rendering issue: > > https://spark.apache.org/docs/3.2.1/running-on-kubernetes.html#configuration > > This PR fixes those typos and resolves the rendering issue. ### Why are the changes needed? Changes from #35561 were in conflict with `branch-3.2`. From original PR: > The typo fixes allows the HTML site to render the article correctly. ### Does this PR introduce _any_ user-facing change? From original PR: > Yes, currently the site shows several headers and closing tags as plain text: > https://spark.apache.org/docs/3.2.1/running-on-kubernetes.html#configuration > > This PR allows those headers to be correctly rendered and no longer shows the table's closing tags. ### How was this patch tested? No tests were added. I did a local build of the site per the instructions and confirmed the HTML renders correctly. Closes #35572 from zr-msft/backport-pr-35561. Authored-by: Microsoft Learn Student <learn@contoso.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
|
@dongjoon-hyun I've periodically checked the docs site and I'm not seeing any changes show up based on commits i've added from this PR:
I'm also not seeing earlier commits show up: The most recent commit that shows up on this page is from Jul 18, 2021: |
|
Hi, @zr-msft . Did you check Apache Spark 3.3 RC5 document? It should be there. For branch-3.2, your contribute arrived after 3.2.1. So, it will be Apache Spark 3.2.2. |
|
thank you @dongjoon-hyun, I made the assumption that the live site was updated after a PR was merged. I see my updates on the rc5 docs and thank you for the quick response |
|
Thank YOU for your contribution. :) |
kazuyukitanimura
pushed a commit
to kazuyukitanimura/spark
that referenced
this pull request
Aug 10, 2022
### What changes were proposed in this pull request? Per [feedback](apache#35561 (comment)) on apache#35561 from dongjoon-hyun, I'm back porting fixes from `master` to `branch-3.2` since there was a conflict. From original PR: > Several `<code>` elements in running-on-kubernetes.md had typos in their closing tags, causing rendering issues on the HTML site. Example of rendering issue: > > https://spark.apache.org/docs/3.2.1/running-on-kubernetes.html#configuration > > This PR fixes those typos and resolves the rendering issue. ### Why are the changes needed? Changes from apache#35561 were in conflict with `branch-3.2`. From original PR: > The typo fixes allows the HTML site to render the article correctly. ### Does this PR introduce _any_ user-facing change? From original PR: > Yes, currently the site shows several headers and closing tags as plain text: > https://spark.apache.org/docs/3.2.1/running-on-kubernetes.html#configuration > > This PR allows those headers to be correctly rendered and no longer shows the table's closing tags. ### How was this patch tested? No tests were added. I did a local build of the site per the instructions and confirmed the HTML renders correctly. Closes apache#35572 from zr-msft/backport-pr-35561. Authored-by: Microsoft Learn Student <learn@contoso.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contribution is my original work and I license the work to the project under the project’s open source license.
What changes were proposed in this pull request?
Several
<code>elements inrunning-on-kubernetes.mdhad typos in their closing tags, causing rendering issues on the HTML site. Example of rendering issue:https://spark.apache.org/docs/3.2.1/running-on-kubernetes.html#configuration
This PR fixes those typos and resolves the rendering issue.
Why are the changes needed?
The typo fixes allows the HTML site to render the article correctly.
Does this PR introduce any user-facing change?
Yes, currently the site shows several headers and closing tags as plain text:
https://spark.apache.org/docs/3.2.1/running-on-kubernetes.html#configuration
This PR allows those headers to be correctly rendered and no longer shows the table's closing tags.
How was this patch tested?
No tests were added. I did a local build of the site per the instructions and confirmed the HTML renders correctly.