Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-37400][SPARK-37426][PYTHON][MLLIB] Inline type hints for pyspark.mllib classification and regression #35585

Closed
wants to merge 3 commits into from

Conversation

zero323
Copy link
Member

@zero323 zero323 commented Feb 20, 2022

What changes were proposed in this pull request?

This PR migrates type pyspark.mllib.classification and pyspark.mllib.regression annotations from stub file to inline type hints.

Why are the changes needed?

Part of ongoing migration of type hints.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing tests.

@HyukjinKwon HyukjinKwon changed the title [WIP][SPARK-37400][SPARK-37426][PYTHON]{MLLIB] Inline type hints for pyspark.mllib classification and regression [WIP][SPARK-37400][SPARK-37426][PYTHON][MLLIB] Inline type hints for pyspark.mllib classification and regression Feb 21, 2022
@zero323 zero323 changed the title [WIP][SPARK-37400][SPARK-37426][PYTHON][MLLIB] Inline type hints for pyspark.mllib classification and regression [SPARK-37400][SPARK-37426][PYTHON][MLLIB] Inline type hints for pyspark.mllib classification and regression Feb 24, 2022
@zero323 zero323 marked this pull request as ready for review February 24, 2022 00:29
Copy link
Contributor

@itholic itholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me

@zero323 zero323 closed this in 18219d4 Mar 6, 2022
@zero323
Copy link
Member Author

zero323 commented Mar 6, 2022

Merged into master.

Thanks @itholic!

@zero323 zero323 deleted the SPARK-37400+SPARK-37426 branch March 6, 2022 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants