[SPARK-38206][SS] Ignore nullability on comparing the data type of join keys on stream-stream join #35599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in keys on stream-stream join
|
I've added test cases for inner & left-outer join. I guess it's redundant to have separate test cases for right-outer/full-outer/left-semi, but please let me know if we would like to have exhausive set of tests. |
cloud-fan
approved these changes
Feb 22, 2022
viirya
approved these changes
Feb 22, 2022
|
Thanks! Merging to master. |
|
Sorry for late comment, just late +1 LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to change the assertion of data type against joining keys on stream-stream join to ignore nullability.
Why are the changes needed?
The existing requirement on checking data types of joining keys is too restricted, as it also requires the same nullability. In batch query (I checked with HashJoinExec), nullability is ignored when checking data types of joining keys.
Does this PR introduce any user-facing change?
Yes, end users will no longer encounter the assertion error on join keys with different nullability in both keys.
How was this patch tested?
New test added.