Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-38486][K8S][TESTS] Upgrade the minimum Minikube version to 1.18.0 #35791

Closed
wants to merge 2 commits into from
Closed

[SPARK-38486][K8S][TESTS] Upgrade the minimum Minikube version to 1.18.0 #35791

wants to merge 2 commits into from

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Mar 9, 2022

What changes were proposed in this pull request?

This PR aims to upgrade the minimum Minikube version to 1.18.0 from 1.7.3 at Apache Spark 3.3.0.

Why are the changes needed?

Minikube v1.18.0 was released one year ago on March 2021, and the first version supporting Apple Silicon natively. Previously, there exists some issues while running Intel arch binary on Apple Silicon.

Does this PR introduce any user-facing change?

No, this is a test-only PR.

How was this patch tested?

Manually.

@dongjoon-hyun
Copy link
Member Author

cc @attilapiros

@dongjoon-hyun
Copy link
Member Author

Could you review this please, @viirya ?

Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dongjoon-hyun
Copy link
Member Author

Thank you so much, @viirya ! Merged to master.

LuciferYang pushed a commit to LuciferYang/spark that referenced this pull request Mar 10, 2022
### What changes were proposed in this pull request?

This PR aims to upgrade the minimum Minikube version to 1.18.0 from 1.7.3 at Apache Spark 3.3.0.

### Why are the changes needed?

Minikube v1.18.0 was released one year ago on March 2021, and the first version supporting Apple Silicon natively. Previously, there exists some issues while running Intel arch binary on Apple Silicon.
- https://github.com/kubernetes/minikube/releases/download/v1.18.0/minikube-darwin-arm64
- https://github.com/kubernetes/minikube/releases/tag/v1.18.0

### Does this PR introduce _any_ user-facing change?

No, this is a test-only PR.

### How was this patch tested?

Manually.

Closes apache#35791 from dongjoon-hyun/SPARK-38486.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants