[SPARK-38379][SPARK-37735][K8S][3.2] Fix Kubernetes Client mode when mounting persistent volume with storage class #35804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
approved these changes
Mar 10, 2022
dongjoon-hyun
changed the title
dongjoon-hyun
pushed a commit
that referenced
this pull request
Mar 10, 2022
…mounting persistent volume with storage class ### What changes were proposed in this pull request? This is the branch-3.2 PR for #35792. Note I also pulled in 068d53b from [SPARK-37735] to pick up adding appId to KubernetesConf. I don't see that as an issue since its private, this was actually the fix I originally had as I was testing on 3.2 and then realized someone added it on master branch. Running spark-shell in client mode on Kubernetes cluster when mounting persistent volumes with a storage class results in a big warning being thrown on startup. https://issues.apache.org/jira/browse/SPARK-38379[](https://github.com/tgravescs) The issue here is there is a race condition between when spark.app.id is set in SparkContext and when its used, so change to use the KubernetesConf appId, which is what is used to set spark.app.id. ### Why are the changes needed? Throws big warning to user and I believe the label is wrong as well. ### Does this PR introduce any user-facing change? No ### How was this patch tested? Unit test added. The test fails without the fix. Also manually tested on real k8s cluster. Closes #35804 from tgravescs/k8smount32. Authored-by: Thomas Graves <tgraves@nvidia.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
kazuyukitanimura
pushed a commit
to kazuyukitanimura/spark
that referenced
this pull request
Aug 10, 2022
…mounting persistent volume with storage class ### What changes were proposed in this pull request? This is the branch-3.2 PR for apache#35792. Note I also pulled in apache@068d53b from [SPARK-37735] to pick up adding appId to KubernetesConf. I don't see that as an issue since its private, this was actually the fix I originally had as I was testing on 3.2 and then realized someone added it on master branch. Running spark-shell in client mode on Kubernetes cluster when mounting persistent volumes with a storage class results in a big warning being thrown on startup. https://issues.apache.org/jira/browse/SPARK-38379[](https://github.com/tgravescs) The issue here is there is a race condition between when spark.app.id is set in SparkContext and when its used, so change to use the KubernetesConf appId, which is what is used to set spark.app.id. ### Why are the changes needed? Throws big warning to user and I believe the label is wrong as well. ### Does this PR introduce any user-facing change? No ### How was this patch tested? Unit test added. The test fails without the fix. Also manually tested on real k8s cluster. Closes apache#35804 from tgravescs/k8smount32. Authored-by: Thomas Graves <tgraves@nvidia.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit a35ea15) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is the branch-3.2 PR for #35792. Note I also pulled in 068d53b from [SPARK-37735] to pick up adding appId to KubernetesConf. I don't see that as an issue since its private, this was actually the fix I originally had as I was testing on 3.2 and then realized someone added it on master branch.
Running spark-shell in client mode on Kubernetes cluster when mounting persistent volumes with a storage class results in a big warning being thrown on startup.
https://issues.apache.org/jira/browse/SPARK-38379[](https://github.com/tgravescs)
The issue here is there is a race condition between when spark.app.id is set in SparkContext and when its used, so change to use the KubernetesConf appId, which is what is used to set spark.app.id.
Why are the changes needed?
Throws big warning to user and I believe the label is wrong as well.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit test added. The test fails without the fix.
Also manually tested on real k8s cluster.