Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-38106][SQL] Use error classes in the parsing errors of functions #35865

Closed
wants to merge 3 commits into from

Conversation

ivoson
Copy link
Contributor

@ivoson ivoson commented Mar 16, 2022

What changes were proposed in this pull request?

Migrate the following errors in QueryExecutionErrors onto use error classes as INVALID_SQL_SYNTAX:

  • functionNameUnsupportedError
  • showFunctionsUnsupportedError
  • showFunctionsInvalidPatternError
  • createFuncWithBothIfNotExistsAndReplaceError
  • defineTempFuncWithIfNotExistsError
  • unsupportedFunctionNameError
  • specifyingDBInCreateTempFuncError
  • invalidNameForDropTempFunc

Why are the changes needed?

Porting parsing errors of functions to new error framework.

Does this PR introduce any user-facing change?

No

How was this patch tested?

UT added.

@github-actions github-actions bot added the SQL label Mar 16, 2022
@ivoson
Copy link
Contributor Author

ivoson commented Mar 16, 2022

cc @MaxGekk

@MaxGekk
Copy link
Member

MaxGekk commented Mar 16, 2022

+1, LGTM. Merging to master.
Thank you, @ivoson.

@MaxGekk MaxGekk closed this in 1b41416 Mar 16, 2022
@ivoson ivoson deleted the SPARK-38106 branch March 16, 2022 11:09
@ivoson
Copy link
Contributor Author

ivoson commented Mar 16, 2022

@MaxGekk Thanks for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants