[SPARK-38643][ML] Validate input dataset of ml.regression #35958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengruifeng
force-pushed
the
regression_validate_training_dataset
branch
from
5be2bbd
to
a9bfcbf
Compare
|
friendly ping @srowen @huaxingao |
srowen
approved these changes
Mar 24, 2022
huaxingao
approved these changes
Mar 25, 2022
|
Merged to master. Thanks! |
|
Thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
validate the input dataset, and fail fast when containing invalid values
Why are the changes needed?
to avoid retruning a bad model silently
Does this PR introduce any user-facing change?
No
How was this patch tested?
added testsuites