Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-34863][SQL][FOLLOWUP] Disable spark.sql.parquet.enableNestedColumnVectorizedReader by default #36055

Closed
wants to merge 1 commit into from

Conversation

sunchao
Copy link
Member

@sunchao sunchao commented Apr 3, 2022

What changes were proposed in this pull request?

This PR disables spark.sql.parquet.enableNestedColumnVectorizedReader by default.

Why are the changes needed?

In #34659 the config was turned mainly for testing reason. As the feature is new, we should turn it off by default.

Does this PR introduce any user-facing change?

The config spark.sql.parquet.enableNestedColumnVectorizedReader is turned off by default now.

How was this patch tested?

Existing tests.

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@viirya
Copy link
Member

viirya commented Apr 4, 2022

Thanks. Merging to master/3.3.

viirya pushed a commit that referenced this pull request Apr 4, 2022
…olumnVectorizedReader` by default

### What changes were proposed in this pull request?

This PR disables `spark.sql.parquet.enableNestedColumnVectorizedReader` by default.

### Why are the changes needed?

In #34659 the config was turned mainly for testing reason. As the feature is new, we should turn it off by default.

### Does this PR introduce _any_ user-facing change?

The config `spark.sql.parquet.enableNestedColumnVectorizedReader` is turned off by default now.

### How was this patch tested?

Existing tests.

Closes #36055 from sunchao/disable.

Authored-by: Chao Sun <sunchao@apple.com>
Signed-off-by: Liang-Chi Hsieh <viirya@gmail.com>
(cherry picked from commit 1b08673)
Signed-off-by: Liang-Chi Hsieh <viirya@gmail.com>
@viirya viirya closed this in 1b08673 Apr 4, 2022
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

dmgburg pushed a commit to joomcode/spark that referenced this pull request Apr 13, 2022
…olumnVectorizedReader` by default

### What changes were proposed in this pull request?

This PR disables `spark.sql.parquet.enableNestedColumnVectorizedReader` by default.

### Why are the changes needed?

In apache#34659 the config was turned mainly for testing reason. As the feature is new, we should turn it off by default.

### Does this PR introduce _any_ user-facing change?

The config `spark.sql.parquet.enableNestedColumnVectorizedReader` is turned off by default now.

### How was this patch tested?

Existing tests.

Closes apache#36055 from sunchao/disable.

Authored-by: Chao Sun <sunchao@apple.com>
Signed-off-by: Liang-Chi Hsieh <viirya@gmail.com>
(cherry picked from commit 1b08673)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants