[SPARK-38802][K8S][TESTS] Add Support for spark.kubernetes.test.(driver|executor)RequestCores
#36087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
approved these changes
Apr 7, 2022
There was a problem hiding this comment.
+1, LGTM. Thank you, @Yikun . Merged to master for Apache Spark 3.4.
Yikun
added a commit
to Yikun/spark
that referenced
this pull request
Sep 20, 2022
…ver|executor)RequestCores` ### What changes were proposed in this pull request? This patch adds support for `spark.kubernetes.test.(driver|executor)RequestCores`, this help devs set specific cores info for (driver|executor)RequestCores. ### Why are the changes needed? In some cases (such as resource limited case), we want to set specifc `RequestCores`. See also: apache#35830 (review) ### Does this PR introduce _any_ user-facing change? No, test only ### How was this patch tested? IT passed Closes apache#36087 from Yikun/SPARK-38802. Authored-by: Yikun Jiang <yikunkero@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
|
@dongjoon-hyun Could we backport this to branch-3.3, this will very help to run branch-3.3 K8S in github action (such as validate specific docker images). also cc @HyukjinKwon |
|
And also this #36096 |
|
Here is a simple demo to show why we need them: Yikun/spark-docker#5
|
|
Sure, @Yikun . This test commit is backported to branch-3.3 according to the community request. |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Sep 20, 2022
…ver|executor)RequestCores` ### What changes were proposed in this pull request? This patch adds support for `spark.kubernetes.test.(driver|executor)RequestCores`, this help devs set specific cores info for (driver|executor)RequestCores. ### Why are the changes needed? In some cases (such as resource limited case), we want to set specifc `RequestCores`. See also: #35830 (review) ### Does this PR introduce _any_ user-facing change? No, test only ### How was this patch tested? IT passed Closes #36087 from Yikun/SPARK-38802. Authored-by: Yikun Jiang <yikunkero@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 8396382) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
|
@dongjoon-hyun Much thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch adds support for
spark.kubernetes.test.(driver|executor)RequestCores, this help devs set specific cores info for (driver|executor)RequestCores.Why are the changes needed?
In some cases (such as resource limited case), we want to set specifc
RequestCores.See also: #35830 (review)
Does this PR introduce any user-facing change?
No, test only
How was this patch tested?
IT passed