[SPARK-38923][TESTS] Regenerate benchmark results #36225
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
approved these changes
Apr 16, 2022
viirya
reviewed
Apr 16, 2022
Comment on lines
+13
to
+16
| Array: Int with unsafe:true 3 3 0 336.3 3.0 88.9X | ||
| Array: Long with unsafe:true 5 5 0 205.6 4.9 54.4X | ||
| Array: Float with unsafe:true 3 3 0 324.1 3.1 85.7X | ||
| Array: Double with unsafe:true 5 5 0 207.2 4.8 54.8X |
There was a problem hiding this comment.
Seems obvious performance regression?
There was a problem hiding this comment.
Given that we change Java version and OS, this small change look okay to me~
- Array: Double with unsafe:true 5 5 0 210.6 4.7 57.1X
+ Array: Double with unsafe:true 5 5 0 207.2 4.8 54.8X
viirya
reviewed
Apr 16, 2022
| Without nested predicate Pushdown 60692 61231 403 1.7 578.8 1.0X | ||
| With nested predicate Pushdown 126 159 37 834.5 1.2 483.0X | ||
| Without nested predicate Pushdown 7005 7074 78 15.0 66.8 1.0X | ||
| With nested predicate Pushdown 44 53 9 2378.0 0.4 158.9X |
There was a problem hiding this comment.
Yes, this could be. Since this is a simple regeneration, we can revisit them one by one.
|
Thank you, @viirya . Since this is a regeneration of benchmark result, I'll merge first. |
|
Thank you @dongjoon-hyun ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This aims to regenerate benchmark results on
masterbranch to compare with Apache Spark 3.3.0 release.Why are the changes needed?
This is a new reference value.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manually verified.