[SPARK-38821][PYTHON] Skip nsmall/nlarge nan test under pandas 1.4.[0,1,2] #36356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yikun
commented
Apr 26, 2022
Comment on lines
+1818
to
+1822
| if not (LooseVersion("1.4.0") <= LooseVersion(pd.__version__) <= LooseVersion("1.4.2")): | ||
| self.assert_eq(psdf.nlargest(5, columns="a"), pdf.nlargest(5, columns="a")) | ||
| self.assert_eq( | ||
| psdf.nlargest(5, columns=["a", "b"]), pdf.nlargest(5, columns=["a", "b"]) | ||
| ) |
There was a problem hiding this comment.
If you still think I need to compare with real results rather than skip, I'd also like to change. We need to change index=np.random.rand(7) to a certain range, and construct a result df.
Because this is only failed with panda 1.4.0~1.4.2, so I thought skip is enough.
|
cc @itholic @xinrong-databricks @HyukjinKwon |
HyukjinKwon
approved these changes
Apr 26, 2022
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Skip nsmall/nlarge nan test under pandas 1.4.[0,1,2].
Pandas get wrong results when
np.nanin the sorting column since pandas-dev/pandas@16d2f59 (v1.4.0)I confirmed this issue are fixed by:
pandas-dev/pandas@2886388
Why are the changes needed?
No
Does this PR introduce any user-facing change?
No
How was this patch tested?
CI passed