[SPARK-39035][SQL][TESTS] Add tests for options from to_csv and from_csv.
#36401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
previously approved these changes
Apr 29, 2022
|
Merged to master. |
|
Sorry, the tests failed https://github.com/apache/spark/runs/6226791783 when ANSI mode ( @itholic can you run the tests with this mode, and make it pass regardless of this configuration? |
|
I reverted this. |
HyukjinKwon
reviewed
Apr 29, 2022
HyukjinKwon
dismissed
their stale review
Approval dismissed since this got reverted.
HyukjinKwon
approved these changes
Apr 30, 2022
itholic
changed the title
to_csv and from_csv.to_csv and from_csv.
tgravescs
approved these changes
Apr 30, 2022
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to fill up the missing test for options from CSV read/write functions.
Why are the changes needed?
For better testability and correct the documents.
Does this PR introduce any user-facing change?
No, it's dev-only.
How was this patch tested?
Added some UTs for CSV read/write options.