[SPARK-38085][SQL][FOLLOWUP] Do not fail too early for DeleteFromTable #36402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks good to me. Just a bit confused by:
So, |
|
When |
viirya
approved these changes
Apr 29, 2022
dongjoon-hyun
approved these changes
Apr 29, 2022
HyukjinKwon
approved these changes
May 2, 2022
|
Merged to master and branch-3.3. |
HyukjinKwon
pushed a commit
that referenced
this pull request
May 2, 2022
### What changes were proposed in this pull request? `DeleteFromTable` has been in Spark for a long time and there are existing Spark extensions to compile `DeleteFromTable` to physical plans. However, the new analyzer rule `RewriteDeleteFromTable` fails very early if the v2 table does not support delete. This breaks certain Spark extensions which can still execute `DeleteFromTable` for certain v2 tables. This PR simply removes the error throwing in `RewriteDeleteFromTable`. It's a safe change because: 1. the new delete-related rules only match v2 table with `SupportsRowLevelOperations`, so won't be affected by this change 2. the planner rule will fail eventually if the v2 table doesn't support deletion. Spark eagerly executes commands so Spark users can still see this error immediately. ### Why are the changes needed? To not break existing Spark extesions. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? existing tests Closes #36402 from cloud-fan/follow. Lead-authored-by: Wenchen Fan <wenchen@databricks.com> Co-authored-by: Wenchen Fan <cloud0fan@gmail.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 5630f70) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
|
LGTM too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
DeleteFromTablehas been in Spark for a long time and there are existing Spark extensions to compileDeleteFromTableto physical plans. However, the new analyzer ruleRewriteDeleteFromTablefails very early if the v2 table does not support delete. This breaks certain Spark extensions which can still executeDeleteFromTablefor certain v2 tables.This PR simply removes the error throwing in
RewriteDeleteFromTable. It's a safe change because:SupportsRowLevelOperations, so won't be affected by this changeWhy are the changes needed?
To not break existing Spark extesions.
Does this PR introduce any user-facing change?
no
How was this patch tested?
existing tests