-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "[SPARK-36837][BUILD] Upgrade Kafka to 3.1.0" #36517
Conversation
This reverts commit 973ea0f.
cc @viirya , @sunchao , @huaxingao , @srowen , @HyukjinKwon , @MaxGekk , @HeartSaVioR for the discussion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me too.
Thank you, @HyukjinKwon , @viirya , @martin-g , @huaxingao , @sunchao . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Btw would you mind if I ask whether there is a specific reason to do so, or just to be conservative?
Thank you, @HeartSaVioR and all.
Merged to branch-3.3. |
### What changes were proposed in this pull request? This PR aims to revert commit 973ea0f from `branch-3.3` to exclude it from Apache Spark 3.3 scope. ### Why are the changes needed? SPARK-36837 tried to use Apache Kafka 3.1.0 at Apache Spark 3.3.0 and initially wanted to upgrade to Apache Kafka 3.3.1 before the official release. However, we can use the stable Apache Kafka 2.8.1 at Spark 3.3.0 and wait for more proven versions, Apache Kafka 3.2.x or 3.3.x. Apache Kafka 3.2.0 vote is already passed and will arrive. - https://lists.apache.org/thread/9k5sysvchg98lchv2rvvvq6xhpgk99cc Apache Kafka 3.3.0 release discussion is started too. - https://lists.apache.org/thread/cmol5bcf011s1xl91rt4ylb1dgz2vb1r ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. Closes #36517 from dongjoon-hyun/SPARK-36837-REVERT. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
For master branch, we are starting to pursue Apache Kafka 3.2.x in Apache Spark 3.4 timeframe. |
Thanks for the detailed explanation! Much appreciated. |
What changes were proposed in this pull request?
This PR aims to revert commit 973ea0f from
branch-3.3
to exclude it from Apache Spark 3.3 scope.Why are the changes needed?
SPARK-36837 tried to use Apache Kafka 3.1.0 at Apache Spark 3.3.0 and initially wanted to upgrade to Apache Kafka 3.3.1 before the official release. However, we can use the stable Apache Kafka 2.8.1 at Spark 3.3.0 and wait for more proven versions, Apache Kafka 3.2.x or 3.3.x.
Apache Kafka 3.2.0 vote is already passed and will arrive.
Apache Kafka 3.3.0 release discussion is started too.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.