Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[SPARK-36837][BUILD] Upgrade Kafka to 3.1.0" #36517

Closed
wants to merge 1 commit into from
Closed

Revert "[SPARK-36837][BUILD] Upgrade Kafka to 3.1.0" #36517

wants to merge 1 commit into from

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented May 12, 2022

What changes were proposed in this pull request?

This PR aims to revert commit 973ea0f from branch-3.3 to exclude it from Apache Spark 3.3 scope.

Why are the changes needed?

SPARK-36837 tried to use Apache Kafka 3.1.0 at Apache Spark 3.3.0 and initially wanted to upgrade to Apache Kafka 3.3.1 before the official release. However, we can use the stable Apache Kafka 2.8.1 at Spark 3.3.0 and wait for more proven versions, Apache Kafka 3.2.x or 3.3.x.

Apache Kafka 3.2.0 vote is already passed and will arrive.

Apache Kafka 3.3.0 release discussion is started too.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the CIs.

@dongjoon-hyun
Copy link
Member Author

cc @viirya , @sunchao , @huaxingao , @srowen , @HyukjinKwon , @MaxGekk , @HeartSaVioR for the discussion.

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this.

Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me too.

@dongjoon-hyun
Copy link
Member Author

Thank you, @HyukjinKwon , @viirya , @martin-g , @huaxingao , @sunchao .

Copy link
Contributor

@HeartSaVioR HeartSaVioR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Btw would you mind if I ask whether there is a specific reason to do so, or just to be conservative?

@dongjoon-hyun
Copy link
Member Author

Thank you, @HeartSaVioR and all.

  • I've been using Kafka 3.1.0 internally to consume the latest updates and there was no serious issue from our side with our setup so far. On top of that, we are going to use Apache Kafka 3.1.1 (with RC1) and catch up 3.2.0 internally in separate Spark versions because we can adapt easily internally if something happens.
  • Apache Spark community has enough discussions from the initial Kafka 3.1 PR and on the mailing list (Thanks to you). I have been agreed all colleagues' valid concerns and grateful to have this trial together. This reverting has been also one of options which was proposed by me from the beginning.
  • This PR adopts all your concerns and tries to choose the best combination of AS-OF-TODAY in terms of the new features, stability and maintainability not only Apache Spark 3.3.0, but also upcoming maintenance versions like Apache Spark 3.3.1, 3.3.2, and 3.3.4.
  • AFAIK, the latest Kafka 3.2 is worth of re-trying in master branch (Apache Spark 3.4 timeframe) because Apache Kafka community is really moving fast toward.

Merged to branch-3.3.

dongjoon-hyun added a commit that referenced this pull request May 12, 2022
### What changes were proposed in this pull request?

This PR aims to revert commit 973ea0f from `branch-3.3` to exclude it from Apache Spark 3.3 scope.

### Why are the changes needed?

SPARK-36837 tried to use Apache Kafka 3.1.0 at Apache Spark 3.3.0 and initially wanted to upgrade to Apache Kafka 3.3.1 before the official release. However, we can use the stable Apache Kafka 2.8.1 at Spark 3.3.0 and wait for more proven versions, Apache Kafka 3.2.x or 3.3.x.

Apache Kafka 3.2.0 vote is already passed and will arrive.
- https://lists.apache.org/thread/9k5sysvchg98lchv2rvvvq6xhpgk99cc

Apache Kafka 3.3.0 release discussion is started too.
- https://lists.apache.org/thread/cmol5bcf011s1xl91rt4ylb1dgz2vb1r

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs.

Closes #36517 from dongjoon-hyun/SPARK-36837-REVERT.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
@dongjoon-hyun dongjoon-hyun deleted the SPARK-36837-REVERT branch May 12, 2022 17:56
@dongjoon-hyun
Copy link
Member Author

For master branch, we are starting to pursue Apache Kafka 3.2.x in Apache Spark 3.4 timeframe.

@HeartSaVioR
Copy link
Contributor

Thanks for the detailed explanation! Much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants