Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-39256][CORE] Reduce multiple file attribute calls of JavaUtils#deleteRecursivelyUsingJavaIO #36636

Closed
wants to merge 3 commits into from
Closed

[SPARK-39256][CORE] Reduce multiple file attribute calls of JavaUtils#deleteRecursivelyUsingJavaIO #36636

wants to merge 3 commits into from

Conversation

LuciferYang
Copy link
Contributor

What changes were proposed in this pull request?

This pr is a minor fix: JavaUtils#deleteRecursivelyUsingJavaIO method performs multiple file attribute calls, this pr change to use Files.readAttributes instead of them.

Why are the changes needed?

Reduce multiple file attribute calls.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Pass Github Actions

@github-actions github-actions bot added the CORE label May 23, 2022
@srowen
Copy link
Member

srowen commented May 23, 2022

Looks fine, but can you try to rerun tests?

@LuciferYang
Copy link
Contributor Author

LuciferYang commented May 23, 2022 •
edited

seems master UTs break

2022-05-23T09:48:27.7668925Z [info] - Hide credentials in show create table *** FAILED *** (43 milliseconds)
2022-05-23T09:48:27.7696056Z [info]   "[0,10000000d5,5420455441455243,62617420454c4241,414e20200a282031,4e4952545320454d,45485420200a2c47,a29544e49204449,726f20474e495355,6568636170612e67,732e6b726170732e,a6362646a2e6c71,20534e4f4954504f,7462642720200a28,203d2027656c6261,45502e5453455427,200a2c27454c504f,6f77737361702720,2a27203d20276472,2a2a2a2a2a2a2a2a,6574636164657228,2720200a2c272964,27203d20276c7275,2a2a2a2a2a2a2a2a,746361646572282a,20200a2c27296465,3d20277265737527,7355747365742720,a29277265]" did not contain "TEST.PEOPLE" (JDBCSuite.scala:1146)
2022-05-23T09:48:27.7697358Z [info]   org.scalatest.exceptions.TestFailedException:
2022-05-23T09:48:27.7697954Z [info]   at org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:472)
2022-05-23T09:48:27.7698605Z [info]   at org.scalatest.Assertions.newAssertionFailedException$(Assertions.scala:471)
2022-05-23T09:48:27.7699211Z [info]   at org.scalatest.Assertions$.newAssertionFailedException(Assertions.scala:1231)
2022-05-23T09:48:27.7699785Z [info]   at org.scalatest.Assertions$AssertionsHelper.macroAssert(Assertions.scala:1295)
2022-05-23T09:48:27.7700358Z [info]   at org.apache.spark.sql.jdbc.JDBCSuite.$anonfun$new$117(JDBCSuite.scala:1146)
2022-05-23T09:48:27.7700946Z [info]   at scala.collection.IndexedSeqOptimized.foreach(IndexedSeqOptimized.scala:36)
2022-05-23T09:48:27.7701557Z [info]   at scala.collection.IndexedSeqOptimized.foreach$(IndexedSeqOptimized.scala:33)
2022-05-23T09:48:27.7702126Z [info]   at scala.collection.mutable.ArrayOps$ofRef.foreach(ArrayOps.scala:198)
2022-05-23T09:48:27.7702799Z [info]   at org.apache.spark.sql.jdbc.JDBCSuite.$anonfun$new$116(JDBCSuite.scala:1144)
2022-05-23T09:48:27.7703346Z [info]   at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:23)
2022-05-23T09:48:27.7703870Z [info]   at org.apache.spark.util.Utils$.tryWithSafeFinally(Utils.scala:1481)
2022-05-23T09:48:27.7704451Z [info]   at org.apache.spark.sql.test.SQLTestUtilsBase.withTable(SQLTestUtils.scala:306)
2022-05-23T09:48:27.7705082Z [info]   at org.apache.spark.sql.test.SQLTestUtilsBase.withTable$(SQLTestUtils.scala:304)
2022-05-23T09:48:27.7705692Z [info]   at org.apache.spark.sql.jdbc.JDBCSuite.withTable(JDBCSuite.scala:48)
2022-05-23T09:48:27.7706491Z [info]   at org.apache.spark.sql.jdbc.JDBCSuite.$anonfun$new$115(JDBCSuite.scala:1131)
2022-05-23T09:48:27.7707032Z [info]   at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:23)
2022-05-23T09:48:27.7707551Z [info]   at org.scalatest.OutcomeOf.outcomeOf(OutcomeOf.scala:85)
2022-05-23T09:48:27.7708053Z [info]   at org.scalatest.OutcomeOf.outcomeOf$(OutcomeOf.scala:83)
2022-05-23T09:48:27.7708544Z [info]   at org.scalatest.OutcomeOf$.outcomeOf(OutcomeOf.scala:104)
2022-05-23T09:48:27.7709026Z [info]   at org.scalatest.Transformer.apply(Transformer.scala:22)
2022-05-23T09:48:27.7709522Z [info]   at org.scalatest.Transformer.apply(Transformer.scala:20)
2022-05-23T09:48:27.7710081Z [info]   at org.scalatest.funsuite.AnyFunSuiteLike$$anon$1.apply(AnyFunSuiteLike.scala:190)
2022-05-23T09:48:27.7710740Z [info]   at org.apache.spark.SparkFunSuite.withFixture(SparkFunSuite.scala:203)
2022-05-23T09:48:27.7711377Z [info]   at org.scalatest.funsuite.AnyFunSuiteLike.invokeWithFixture$1(AnyFunSuiteLike.scala:188)
2022-05-23T09:48:27.7712015Z [info]   at org.scalatest.funsuite.AnyFunSuiteLike.$anonfun$runTest$1(AnyFunSuiteLike.scala:200)
2022-05-23T09:48:27.7712561Z [info]   at org.scalatest.SuperEngine.runTestImpl(Engine.scala:306)
2022-05-23T09:48:27.7713121Z [info]   at org.scalatest.funsuite.AnyFunSuiteLike.runTest(AnyFunSuiteLike.scala:200)
2022-05-23T09:48:27.7713713Z [info]   at org.scalatest.funsuite.AnyFunSuiteLike.runTest$(AnyFunSuiteLike.scala:182)
2022-05-23T09:48:27.7714354Z [info]   at org.apache.spark.SparkFunSuite.org$scalatest$BeforeAndAfterEach$$super$runTest(SparkFunSuite.scala:64)
2022-05-23T09:48:27.7714968Z [info]   at org.scalatest.BeforeAndAfterEach.runTest(BeforeAndAfterEach.scala:234)
2022-05-23T09:48:27.7715541Z [info]   at org.scalatest.BeforeAndAfterEach.runTest$(BeforeAndAfterEach.scala:227)
2022-05-23T09:48:27.7716158Z [info]   at org.apache.spark.sql.jdbc.JDBCSuite.org$scalatest$BeforeAndAfter$$super$runTest(JDBCSuite.scala:48)
2022-05-23T09:48:27.7716733Z [info]   at org.scalatest.BeforeAndAfter.runTest(BeforeAndAfter.scala:213)
2022-05-23T09:48:27.7717270Z [info]   at org.scalatest.BeforeAndAfter.runTest$(BeforeAndAfter.scala:203)
2022-05-23T09:48:27.7717813Z [info]   at org.apache.spark.sql.jdbc.JDBCSuite.runTest(JDBCSuite.scala:48)
2022-05-23T09:48:27.7718398Z [info]   at org.scalatest.funsuite.AnyFunSuiteLike.$anonfun$runTests$1(AnyFunSuiteLike.scala:233)
2022-05-23T09:48:27.7718974Z [info]   at org.scalatest.SuperEngine.$anonfun$runTestsInBranch$1(Engine.scala:413)
2022-05-23T09:48:27.7719487Z [info]   at scala.collection.immutable.List.foreach(List.scala:431)
2022-05-23T09:48:27.7720016Z [info]   at org.scalatest.SuperEngine.traverseSubNodes$1(Engine.scala:401)
2022-05-23T09:48:27.7720554Z [info]   at org.scalatest.SuperEngine.runTestsInBranch(Engine.scala:396)
2022-05-23T09:48:27.7721076Z [info]   at org.scalatest.SuperEngine.runTestsImpl(Engine.scala:475)
2022-05-23T09:48:27.7721641Z [info]   at org.scalatest.funsuite.AnyFunSuiteLike.runTests(AnyFunSuiteLike.scala:233)
2022-05-23T09:48:27.7722297Z [info]   at org.scalatest.funsuite.AnyFunSuiteLike.runTests$(AnyFunSuiteLike.scala:232)
2022-05-23T09:48:27.7722872Z [info]   at org.scalatest.funsuite.AnyFunSuite.runTests(AnyFunSuite.scala:1563)
2022-05-23T09:48:27.7723355Z [info]   at org.scalatest.Suite.run(Suite.scala:1112)
2022-05-23T09:48:27.7723787Z [info]   at org.scalatest.Suite.run$(Suite.scala:1094)
2022-05-23T09:48:27.7734912Z [info]   at org.scalatest.funsuite.AnyFunSuite.org$scalatest$funsuite$AnyFunSuiteLike$$super$run(AnyFunSuite.scala:1563)
2022-05-23T09:48:27.7735578Z [info]   at org.scalatest.funsuite.AnyFunSuiteLike.$anonfun$run$1(AnyFunSuiteLike.scala:237)
2022-05-23T09:48:27.7736113Z [info]   at org.scalatest.SuperEngine.runImpl(Engine.scala:535)
2022-05-23T09:48:27.7736675Z [info]   at org.scalatest.funsuite.AnyFunSuiteLike.run(AnyFunSuiteLike.scala:237)
2022-05-23T09:48:27.7737441Z [info]   at org.scalatest.funsuite.AnyFunSuiteLike.run$(AnyFunSuiteLike.scala:236)
2022-05-23T09:48:27.7738075Z [info]   at org.apache.spark.SparkFunSuite.org$scalatest$BeforeAndAfterAll$$super$run(SparkFunSuite.scala:64)
2022-05-23T09:48:27.7738690Z [info]   at org.scalatest.BeforeAndAfterAll.liftedTree1$1(BeforeAndAfterAll.scala:213)
2022-05-23T09:48:27.7739261Z [info]   at org.scalatest.BeforeAndAfterAll.run(BeforeAndAfterAll.scala:210)
2022-05-23T09:48:27.7739809Z [info]   at org.scalatest.BeforeAndAfterAll.run$(BeforeAndAfterAll.scala:208)
2022-05-23T09:48:27.7740411Z [info]   at org.apache.spark.sql.jdbc.JDBCSuite.org$scalatest$BeforeAndAfter$$super$run(JDBCSuite.scala:48)
2022-05-23T09:48:27.7740976Z [info]   at org.scalatest.BeforeAndAfter.run(BeforeAndAfter.scala:273)
2022-05-23T09:48:27.7741492Z [info]   at org.scalatest.BeforeAndAfter.run$(BeforeAndAfter.scala:271)
2022-05-23T09:48:27.7742012Z [info]   at org.apache.spark.sql.jdbc.JDBCSuite.run(JDBCSuite.scala:48)
2022-05-23T09:48:27.7742583Z [info]   at org.scalatest.tools.Framework.org$scalatest$tools$Framework$$runSuite(Framework.scala:318)
2022-05-23T09:48:27.7743347Z [info]   at org.scalatest.tools.Framework$ScalaTestTask.execute(Framework.scala:513)
2022-05-23T09:48:27.7743842Z [info]   at sbt.ForkMain$Run.lambda$runTest$1(ForkMain.java:413)
2022-05-23T09:48:27.7744321Z [info]   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
2022-05-23T09:48:27.7744909Z [info]   at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
2022-05-23T09:48:27.7745525Z [info]   at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
2022-05-23T09:48:27.7746016Z [info]   at java.lang.Thread.run(Thread.java:750)

https://github.com/apache/spark/runs/6552100534?check_suite_focus=true

https://github.com/apache/spark/runs/6553260387?check_suite_focus=true

@LuciferYang
Copy link
Contributor Author

127a515 merge with master and rerun all tests

@LuciferYang
Copy link
Contributor Author

Looks fine, but can you try to rerun tests?

GA passed

@srowen srowen closed this in 0bb54ec May 24, 2022
@srowen
Copy link
Member

srowen commented May 24, 2022

Merged to master

@LuciferYang
Copy link
Contributor Author

thanks @srowen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srowen srowen srowen approved these changes

Assignees
No one assigned
Labels
CORE
Projects
None yet
Milestone
No milestone
2 participants
@LuciferYang @srowen