-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-39259][SQL] Evaluate timestamps consistently in subqueries #36654
Closed
Closed
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
5f20717
[SPARK-39259] Evaluate timestamps consistently in subqueries
olaky ff68d5b
wip
olaky 8075b25
Use Instant for CurrentDate, more test coverage
olaky 7897342
Add pruning for subqueries, fix scalastyle
olaky a854a37
Comment why there is an extension point not used in Spark
olaky e9e2c69
Java 8 compliant local date conversion
olaky 60b4bcf
Add explicit cast to fix compilation
olaky 87e1d92
Use DateTimeUtils.microsToDays
olaky d70ea4d
Remove unused import
olaky a242bcf
Inline applyWithTimestamp
olaky e48dc4c
Remove asInstanceOf casts
olaky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of modifying this method's signature, I slightly prefer adding an overload named
transformDownWithSubqueriesAndPruning
in order to remain consistent with the naming conventions for other transform methods.Adding a new method also avoids introducing source or binary compatibility issues for third-party code that calls Catalyst APIs. Technically speaking, Catalyst APIs are considered internal to Spark and are subject to change between minor releases (see source), but I think it's nice to try to avoid API breakage when feasible.
I also ran into problems when trying to call
transformDownWithSubqueries
without supplying any arguments in the first argument group: callingtransformDownWithSubqueries() { f }
resulted in confusing compilation errors.As a result, I'm going to submit a followup to this PR to split this into two methods as I've suggested above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's my PR: #36765