[SPARK-39282][SQL] Replace If-Else branch with bitwise operators in roundNumberOfBytesToNearestWord #36659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @cloud-fan @ueshin , Please give a review, thanks! |
cloud-fan
approved these changes
May 25, 2022
srowen
approved these changes
May 25, 2022
|
Can one of the admins verify this patch? |
|
Thanks @cloud-fan @srowen , can it be merged? |
|
The GA job didn't pass, can you check? |
Hi @cloud-fan @srowen |
|
I think the appveyor error is unrelated. I'll merge shortly |
|
MErged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use bitwise operators to avoid If-Else branch and improve computation performance.
How was this patch tested?
Existed UTs.