[SPARK-38700][SQL][3.3] Use error classes in the execution errors of save mode #36676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
@panbingkun Could you resolve conflicts, please. |
sorry, I've been busy for the last two weeks, i will do it the weekend. |
|
ping @MaxGekk, I have finished it |
MaxGekk
reviewed
Jun 12, 2022
Comment on lines
+80
to
93
| val (displayClass, displayMessageParameters, displayFormat) = if (errorInfo.subClass.isEmpty) { | ||
| (errorClass, messageParameters, errorInfo.messageFormat) | ||
| } else { | ||
| val subClass = errorInfo.subClass.get | ||
| val subErrorClass = messageParameters.head | ||
| val errorSubInfo = subClass.getOrElse(subErrorClass, | ||
| throw new IllegalArgumentException(s"Cannot find sub error class '$subErrorClass'")) | ||
| (errorClass + "." + subErrorClass, messageParameters.tail, | ||
| errorInfo.messageFormat + " " + errorSubInfo.messageFormat) | ||
| } | ||
| val displayMessage = String.format( | ||
| displayFormat.replaceAll("<[a-zA-Z0-9_-]+>", "%s"), | ||
| displayMessageParameters : _*) | ||
| val displayQueryContext = if (queryContext.isEmpty) { |
There was a problem hiding this comment.
Could you not include the changes into the PR. If you you changes strongly require them, let's don't backport it.
There was a problem hiding this comment.
ok, i will close it and open new pr for it!
new pr: #36852
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Migrate the following errors in QueryExecutionErrors:
Why are the changes needed?
Porting execution errors of unsupported saveMode to new error framework.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Add new UT.